minor update

Signed-off-by: wangbaiping(wbpcode) <wangbaiping@bytedance.com>
envoyproxy · Jan 26, 2025 · 98b9968 · 98b9968
1 parent 46d3295
commit 98b9968
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 8 deletions.
diff --git a/api/envoy/extensions/filters/network/generic_proxy/v3/generic_proxy.proto b/api/envoy/extensions/filters/network/generic_proxy/v3/generic_proxy.proto
@@ -74,5 +74,5 @@ message GenericRds {
 //
 //   If the ``envoy.access_loggers.file`` logger is used for generic proxy, this formatter will
 //   be enabled by default.
-message GenericProxyLogFormatter {
+message GenericProxySubstitutionFormatter {
 }
diff --git a/changelogs/current.yaml b/changelogs/current.yaml
@@ -105,9 +105,9 @@ new_features:
 - area: generic_proxy
   change: |
     Added :ref:`generic proxy log formatter support
-    <envoy_v3_api_msg_extensions.filters.network.generic_proxy.v3.GenericProxyLogFormatter>` which could be configured
-    at the :ref:`formatters <envoy_v3_api_field_config.core.v3.SubstitutionFormatString.formatters>` extension point
-    of logger to support generic proxy specific substitution commands. And all access loggers could be used in
-    generic proxy now.
+    <envoy_v3_api_msg_extensions.filters.network.generic_proxy.v3.GenericProxySubstitutionFormatter>` which could be
+    configured at the :ref:`formatters <envoy_v3_api_field_config.core.v3.SubstitutionFormatString.formatters>`
+    extension point of logger to support generic proxy specific substitution commands. And all access loggers could be
+    used in generic proxy now.
 
 deprecated:
diff --git a/source/extensions/filters/network/generic_proxy/access_log.cc b/source/extensions/filters/network/generic_proxy/access_log.cc
@@ -153,8 +153,8 @@ class GenericProxyCommandParserFactory : public Formatter::CommandParserFactory
     return createGenericProxyCommandParser();
   }
   ProtobufTypes::MessagePtr createEmptyConfigProto() override {
-    return std::make_unique<
-        envoy::extensions::filters::network::generic_proxy::v3::GenericProxyLogFormatter>();
+    return std::make_unique<envoy::extensions::filters::network::generic_proxy::v3::
+                                GenericProxySubstitutionFormatter>();
   }
 
   std::string name() const override { return "envoy.formatters.generic_proxy_commands"; }
@@ -191,7 +191,8 @@ absl::Status initializeFormatterForFileLogger(
         "Access log: no format and no default format for file access log");
   }
 
-  envoy::extensions::filters::network::generic_proxy::v3::GenericProxyLogFormatter formatter;
+  envoy::extensions::filters::network::generic_proxy::v3::GenericProxySubstitutionFormatter
+      formatter;
   auto* formatter_extension = config.mutable_log_format()->mutable_formatters()->Add();
   formatter_extension->set_name("envoy.formatters.generic_proxy_commands");
   formatter_extension->mutable_typed_config()->PackFrom(formatter);