Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dfp: allowing the dfp cluster to do dns lookups #38237

Merged
merged 5 commits into from
Feb 4, 2025

comments

23a3b94
Select commit
Loading
Failed to load commit list.
Merged

dfp: allowing the dfp cluster to do dns lookups #38237

comments
23a3b94
Select commit
Loading
Failed to load commit list.
CI (Envoy) / Mobile/Android skipped Feb 4, 2025 in 0s

Check was skipped

This check was not triggered in this CI run

Details

Request (pr/38237/main@23a3b94)

alyssawilk @alyssawilk 23a3b94 #38237 merge main@057f7e0

dfp: allowing the dfp cluster to do dns lookups

This allows bypassing the DFP for most DFP use. It does not yet support the use case use_subcluster_config at which point DFP is still required.

Risk Level: meidum
Testing: MORE NEEDED
Docs Changes: n/a
Release Notes: inline
[Optional Runtime guard:] envoy.reloadable_features.dfp_cluster_resolves_hosts

Environment

Request variables

Key Value
ref 0fd5490
sha 23a3b94
pr 38237
base-sha 057f7e0
actor alyssawilk @alyssawilk
message dfp: allowing the dfp cluster to do dns lookups...
started 1738679918.786473
target-branch main
trusted false
Build image

Container image/s (as used in this CI run)

Key Value
default envoyproxy/envoy-build-ubuntu:d2be0c198feda0c607fa33209da01bf737ef373f
mobile envoyproxy/envoy-build-ubuntu:mobile-d2be0c198feda0c607fa33209da01bf737ef373f
Version

Envoy version (as used in this CI run)

Key Value
major 1
minor 34
patch 0
dev true