Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

erlc: Send warnings and errors to stderr #9363

Merged
merged 1 commit into from
Jan 31, 2025

Conversation

bjorng
Copy link
Contributor

@bjorng bjorng commented Jan 30, 2025

erlc used to send all output to stdout, in contrast to other language compilers such as gcc and clang, which send diagnostics to stderr.

Fixes #9255

@bjorng bjorng added team:VM Assigned to OTP team VM enhancement labels Jan 30, 2025
@bjorng bjorng requested a review from garazdawi January 30, 2025 11:29
@bjorng bjorng self-assigned this Jan 30, 2025
Copy link
Contributor

github-actions bot commented Jan 30, 2025

CT Test Results

    5 files    285 suites   2h 56m 54s ⏱️
5 065 tests 4 730 ✅ 333 💤 2 ❌
6 447 runs  6 037 ✅ 408 💤 2 ❌

For more details on these failures, see this check.

Results for commit 4856a63.

♻️ This comment has been updated with latest results.

To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass.

See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally.

Artifacts

// Erlang/OTP Github Action Bot

`erlc` used to send all output to stdout, in contrast to other
language compilers such as `gcc` and `clang`, which send diagnostics
to stderr.

Fixes erlang#9255
@bjorng bjorng force-pushed the bjorn/erlc-output/GH-9255/OTP-19460 branch from 867f861 to 4856a63 Compare January 30, 2025 11:45
@bjorng bjorng added the testing currently being tested, tag is used by OTP internal CI label Jan 30, 2025
Copy link
Contributor

@garazdawi garazdawi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@bjorng bjorng merged commit c0ada58 into erlang:master Jan 31, 2025
24 of 27 checks passed
@bjorng bjorng deleted the bjorn/erlc-output/GH-9255/OTP-19460 branch January 31, 2025 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement team:VM Assigned to OTP team VM testing currently being tested, tag is used by OTP internal CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

erlc warnings are sent to stdout instead of to stderr
2 participants