Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sponsor logo misalignment #471

Merged
merged 1 commit into from
Mar 9, 2024

Conversation

juhalehtonen
Copy link
Collaborator

  • I acknowledge my contribution to the website does not assert comparative or superlative differences of one product, project, company or individual over another.

Description

This MR adds Bootstrap CSS classes to fix misalignment issues when presenting sponsor logos. With the new CSS classes applied the logos are more evenly aligned on each row, leading to a cleaner presentation.

Screenshots

Sponsors page, old and new look

Old CSS classes
erlef-old2

New CSS classes
erlef-new2

Footer, old and new look

Old CSS classes
erlef-old

New CSS classes
erlef-new

@juhalehtonen
Copy link
Collaborator Author

Some CI jobs are failing, but those seem to have already failed at https://github.com/erlef/website/actions/runs/7457194511 and don't seem to be related to the diff here.

@juhalehtonen juhalehtonen requested a review from starbelly March 8, 2024 09:25
@starbelly
Copy link
Member

Thank you @juhalehtonen this looks fantastic!

@starbelly starbelly merged commit ef02d28 into erlef:main Mar 9, 2024
4 of 6 checks passed
starbelly pushed a commit that referenced this pull request Mar 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants