Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update etcdutl migrate command: load wal records from the latest snapshot #19128

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

ahrtr
Copy link
Member

@ahrtr ahrtr commented Jan 6, 2025

Copy link

codecov bot commented Jan 6, 2025

Codecov Report

Attention: Patch coverage is 52.94118% with 8 lines in your changes missing coverage. Please review.

Project coverage is 68.75%. Comparing base (75f2ae1) to head (ec52e35).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
etcdutl/etcdutl/migrate_command.go 52.94% 6 Missing and 2 partials ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
etcdutl/etcdutl/migrate_command.go 9.78% <52.94%> (+9.78%) ⬆️

... and 19 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #19128      +/-   ##
==========================================
+ Coverage   68.74%   68.75%   +0.01%     
==========================================
  Files         420      420              
  Lines       35647    35663      +16     
==========================================
+ Hits        24504    24521      +17     
- Misses       9713     9717       +4     
+ Partials     1430     1425       -5     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 75f2ae1...ec52e35. Read the comment docs.

@ahrtr ahrtr marked this pull request as draft January 7, 2025 08:10
@serathius
Copy link
Member

/retest

serathius
serathius previously approved these changes Jan 7, 2025
@ahrtr ahrtr force-pushed the etcdutl_migrate_20250106 branch from 5386eef to 44cb583 Compare January 7, 2025 14:00
@ahrtr ahrtr marked this pull request as ready for review January 7, 2025 14:00
@serathius serathius dismissed their stale review January 7, 2025 14:06

Changes in server/etcdserver/apply/apply.go

@ahrtr ahrtr force-pushed the etcdutl_migrate_20250106 branch from 44cb583 to 7f7ebde Compare January 7, 2025 16:18
@ahrtr ahrtr force-pushed the etcdutl_migrate_20250106 branch from 7f7ebde to b99b962 Compare January 8, 2025 16:02
…shot

Signed-off-by: Benjamin Wang <benjamin.ahrtr@gmail.com>
@ahrtr ahrtr force-pushed the etcdutl_migrate_20250106 branch from 28b7087 to ec52e35 Compare January 9, 2025 14:39
@ahrtr
Copy link
Member Author

ahrtr commented Jan 9, 2025

/test pull-etcd-integration-1-cpu-amd64

Copy link
Member

@fuweid fuweid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on green

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, fuweid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ahrtr
Copy link
Member Author

ahrtr commented Jan 9, 2025

/test pull-etcd-robustness-arm64

@ahrtr ahrtr merged commit 0e45288 into etcd-io:main Jan 9, 2025
34 checks passed
@ahrtr ahrtr deleted the etcdutl_migrate_20250106 branch January 9, 2025 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Etcdutl migrate should read WAL from last snapshot
4 participants