Stage #8751
Merged
Stage #8751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 2119a1e.
This reverts commit ed1e52c.
* chore(deps): remove pm2 (^5.3.1) as it's no longer needed * chore: remove unused pm2bootstrap.ts files & commands * chore(env): remove PM2-related variables from multiple .env files * chore(ci): remove PM2-related secrets from YAML configuration files * fix(cspell): typo spelling :-) * fix(cspell): typo spelling :-) * Update Dockerfile --------- Co-authored-by: Ruslan Konviser <evereq@gmail.com>
[Chore] Package Updates
[Chore] Package Updates
[Feat] Tag Type
…-admin [Fix] #8703 Change Role For Super Admin
This reverts commit 5f369ff.
…ts-relations [Fix] Dashboard Relation and Widget Module
* refactor: window management and electron store Moves window management related code into a dedicated directory. Removes electron-log and type definitions for electron store. Electron store is now handled globally in a dedicated module. Console logging will be handled by the renderer process. * refactor: store and adds logger utility Moves store related services into a dedicated store directory. Introduces a new logger utility for better logging and debugging. The logger is initialized and setup for Electron. * refactor: desktop store to use core services Replaces direct `electron-store` usage with core services for managing application settings, configurations, authentication, and project information. This change improves code organization, reduces redundancy, and promotes consistency with the core application logic. It centralizes data management and simplifies updates to the stored data. * refactor: config management and logging Centralizes environment variable assignment to `environment.ts`. Improves theme preference handling by simplifying the logic and setting a default theme if no setting exists. Updates server start logic to directly update config store instead of using a temporary object. Moves logging setup and node modules path output to after environment setup. Removes redundant `electron-log` imports and uses `@gauzy/desktop-core` logger. Refactors and simplifies setting default config by using `LocalStore.setAllDefaultConfig`. Simplifies timer duration update logging. * feat(desktop-core): add optional db field to IConfig interface - Introduced an optional `db` property to the `IConfig` interface to allow for database configuration specifications. - This change enables more flexible configurations within the desktop core setup.
…ster chore(deps): #8701 remove angular2-toaster package
[Refactor] Config Loader & File Provider
* feat: scaffolding videos ui package Generate videos ui plugin package using NX tools * feat: adds video tab to employee activity page Integrates the `@gauzy/videos-ui` plugin to display employee videos within the activity tab section. This adds a new "Videos" tab alongside screenshots, app activity, and URLs, allowing for comprehensive tracking of employee activity. The tab's content is loaded from the `VideoUiModule` and is accessible under the 'time-activity' location. Permissions for the new tab are consistent with other activity tracking features. * feat: implements vertical video list view Adds an input to the video list component to allow switching to a vertical layout. Updates styling for both the video list and individual video items to support vertical orientation. Modifies the video detail page to display the video list vertically. * feat: improves video detail page UI Adds a "more actions" icon to the video title area. Sets a minimum width for the video list to prevent layout issues. Updates the video detail page title to be more concise. * feat: adds action buttons to video components Introduces action buttons for common video operations like download, edit, share, and delete. This change improves the user experience by providing quick access to these actions directly within the video list and detail views. The download button is displayed prominently, while other actions are grouped under a menu. * feat: implements video edit and delete actions Adds edit and delete actions to the video list. Includes a confirmation dialog before deleting a video. Updates the video details page to use change detection. Adds toast notifications for successful updates and deletions. * feat: formats video duration in video item component Applies the `durationFormat` pipe to the displayed video duration. This improves the readability of the duration. * fix: video navigation on details page Handles route reuse strategy to navigate correctly to video details. Previously, navigating between videos on the details page would result in incorrect routing due to route reuse. This change updates the navigation logic to account for the route reuse strategy, ensuring consistent navigation behavior. * refactor: video edit component to shared module Moves the `VideoEditComponent` from the `video-edit` feature module to the `shared/ui` module. This change improves code reusability and organization by placing the video edit component in a shared location, making it accessible to other modules. * feat: implements video metadata Adds dialogs for viewing video metadata. Updates the video action buttons to open the respective dialogs. * fix: use custom video sharing with Web Share API Uses the Web Share API for sharing videos directly from the browser. This change adds use the native Web Share API. The share button is now dynamically hidden if the user's browser does not support the Web Share API. * feat: improves video sharing with toast notifications Replaces console logs with toast notifications for user feedback during video sharing. This provides more informative messages for share success, cancellation, errors, and clipboard copy. Also removes unnecessary share data from the share tracking event. * fix: video player width and removes console log Sets a maximum width for the video player to prevent it from overflowing its container. Removes a debug console log from the video update effect. * feat: adds video sharing functionality Implements sharing videos via Web Share API. Adds a new action, effect, and service to handle sharing. Updates the video component and video item component to use the new functionality. * feat: adds video download functionality Implements video download feature using a download queue service. Adds actions, effects, and UI elements to support adding and removing videos from the queue. Integrates a download manager component to display and manage queued downloads. Updates the video player and video item components to trigger the download action. * fix: refactors download queue observables Renames BehaviorSubject properties to use a leading underscore for internal state management. This improves code clarity and consistency. * fix: duplicate downloads in video UI Handles empty or null URL input and prevents adding duplicate URLs to the download queue. Cancels ongoing downloads before removing them from the queue. Improves download status check by handling potentially missing download data. * feat: improves video download manager UI/UX Redesigns the video download manager to enhance the user experience. Adds a retry download button for failed downloads. Displays download progress with a progress bar and file size information. Improves the overall layout and styling for better clarity. * feat: displays video download manager as popover Moves the video download manager to a popover that is displayed when hovering over the download button in the video component. Adds no-data message to download manager when the queue is empty. Updates styling for the download manager and progress bar. * Styles video download manager items Increases spacing between video download manager items and changes the filename text from h4 to h6 for better visual hierarchy. * perf: preloads video metadata Adds `preload="metadata"` attribute to the video element. This optimizes video loading by preloading metadata such as duration and dimensions before the user initiates playback. This improves the user experience by allowing the player to display information like duration and prepare for playback more quickly. * feat: improves video UI with placeholders and layout Adds placeholder skeletons for video list and individual video components to improve user experience during loading. Removes unnecessary conditional rendering of video list and video player, simplifying the component logic. Adjusts video title styling for better visual presentation. Adds `w-100` class to video component on the detail page for responsive layout. Removes unnecessary conditional check for video URL in video item component. * fix: video reload on route change Reloads the video player when the route changes to a new video. This change addresses an issue where the video player would not reload when navigating between different videos. The `videoPlayer` component now has a public `player` property that exposes the underlying HTMLVideoElement. The `VideoComponent` now uses `@ViewChild` to access the `videoPlayer` and calls its `load` method when the `video$` observable emits a new value. This ensures that the video player correctly reloads and plays the new video when the route changes. * enhance: shows toastr notifications for download status changes Implements toastr notifications to inform the user about the status of their downloads, including start, completion, and failure. This improvement enhances the user experience by providing real-time feedback during the download process. * enhance: improves download filename handling Uses a new utility function to extract filenames from URLs for downloads, providing a default filename if extraction fails. This improves the handling of filenames in download notifications and the saved files. * feat: improves video list loading and display Implements infinite scrolling for video lists on both the main video page and the video detail page. This enhances the user experience by loading videos on demand as the user scrolls down, preventing initial page load times from being excessively long when dealing with many videos. It also adds a new action and effect to fetch videos while excluding a specific video ID, which is used on the video detail page to avoid displaying the currently viewed video in the related videos list. Additionally, the related videos list on the video details page now utilizes the infinite scroll functionality for loading more videos. * refactor: video components and improves UX - Extracts filename from URL using a utility function for consistency. - Improves dialog handling by ensuring single emissions on close. - Improves UX by resetting scroll position and skip value on navigation within video details. - Uses untilDestroyed operator to prevent memory leaks in subscriptions. * fix: removes unused video-preview component and related files. Moves download-related services and components into the video-ui module for better organization. Updates imports accordingly. * feat: adds video page filters Adds support for saving filter state. Removes employee filter from video page selectors. Updates video page to use new filter structure. * feat: improves video UI with loading and error states Adds loading and error states to the video player and video list components. Includes a skeleton loader for initial loading and a loading indicator during video retrieval. Displays user-friendly messages for video not found errors. Also improves styling with rounded corners for skeleton loaders. * feat: improves video list loading state Adds a loading indicator to the video list page while videos are being fetched. Displays a "No video found" message if no videos are available after loading. Sets a minimum placeholder display time for a smoother user experience. * feat: hides video tab if no videos are available Introduces a check for video availability and dynamically adds/removes the "Videos" tab in the employee activity layout based on the presence of videos. This prevents displaying an empty video tab when no videos exist, improving the user experience. * fix: cspell spelling * fix: cspell spelling * fix: file saving error handling Improves error handling and resource cleanup in the `FileSaveStrategy`. Adds checks for valid blob and filename inputs. Wraps file saving operations in a try-catch block to handle potential errors. Ensures removal of the temporary link element and revocation of the blob URL in a finally block. * fix: sanitizes video source URL Uses `DomSanitizer` to bypass security and prevent XSS vulnerabilities when binding to the `src` attribute of the video player. This ensures that untrusted URLs are handled safely. * fix: adds rel="noopener noreferrer" to external link Improves security by adding `rel="noopener noreferrer"` to the external link for viewing the full video. This prevents the linked site from accessing the original page's `window` object and mitigates potential security risks. --------- Co-authored-by: adkif <akifungo@gmail.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
|
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 15092885 | Triggered | Generic High Entropy Secret | 5a9d23c | packages/core/src/lib/tenant-api-key/tenant-api-key.service.ts | View secret |
| 15092886 | Triggered | Generic High Entropy Secret | 46c62c2 | packages/core/src/lib/tenant-api-key/tenant-api-key.service.ts | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
|
View your CI Pipeline Execution ↗ for commit e8b67d5.
☁️ Nx Cloud last updated this comment at |
[Fix] Docker Packages Build
|
👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎ This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. |
…o-player.component.ts Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
[Fix] Plugin Video UI Package
[Fix] Deep Scan
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR
Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.