Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Spiral Matrix Exercise #625

Merged
merged 3 commits into from
Feb 21, 2024

Conversation

tomasnorre
Copy link
Contributor

@tomasnorre tomasnorre commented Feb 21, 2024

I was just in the flow. Hope that's OK? I'll post a link in the forum too.

https://forum.exercism.org/t/implement-some-missing-php-exercises-for-48in24/9865

Copy link
Collaborator

@neenjaw neenjaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tomasnorre tomasnorre force-pushed the add-spiral-matrix-exercise branch from dff4d71 to a385541 Compare February 21, 2024 19:47
@mk-mxp mk-mxp added x:action/create Work on something from scratch x:knowledge/elementary Little Exercism knowledge required x:module/practice-exercise Work on Practice Exercises x:size/large Large amount of work x:rep/large Large amount of reputation labels Feb 21, 2024
Copy link
Contributor

@mk-mxp mk-mxp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are both optional. Resolve the threads, if you want me to merge it as is.

exercises/practice/spiral-matrix/.meta/example.php Outdated Show resolved Hide resolved
exercises/practice/spiral-matrix/SpiralMatrix.php Outdated Show resolved Hide resolved
@mk-mxp mk-mxp merged commit 2b9223f into exercism:main Feb 21, 2024
12 checks passed
@mk-mxp
Copy link
Contributor

mk-mxp commented Feb 21, 2024

Thanks a lot for contributing! And don't stop the flow...

@tomasnorre tomasnorre deleted the add-spiral-matrix-exercise branch February 22, 2024 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
x:action/create Work on something from scratch x:knowledge/elementary Little Exercism knowledge required x:module/practice-exercise Work on Practice Exercises x:rep/large Large amount of reputation x:size/large Large amount of work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants