Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Kindergarten Garden Exercise #632

Merged
merged 2 commits into from
Feb 22, 2024
Merged

Add Kindergarten Garden Exercise #632

merged 2 commits into from
Feb 22, 2024

Conversation

tomasnorre
Copy link
Contributor

We didn't agree on this directly on this, but I mentioned that I would pick one to work on, so hope you will still accept it.

http://forum.exercism.org/t/implement-some-missing-php-exercises-for-48in24/9865/11

mk-mxp
mk-mxp requested changes Feb 22, 2024
View reviewed changes
Copy link
Contributor

@mk-mxp mk-mxp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for the contribution! [joke] I wonder how much you could do if you actually had time to add an exercise every two weeks [/joke].

exercises/practice/kindergarten-garden/.meta/example.php Outdated Show resolved Hide resolved
exercises/practice/kindergarten-garden/KindergartenGardenTest.php Show resolved Hide resolved
exercises/practice/kindergarten-garden/KindergartenGarden.php Show resolved Hide resolved
@mk-mxp mk-mxp added x:action/create Work on something from scratch x:knowledge/elementary Little Exercism knowledge required x:module/practice-exercise Work on Practice Exercises x:size/large Large amount of work x:rep/large Large amount of reputation labels Feb 22, 2024
This was referenced Feb 22, 2024
Open
Closed
@tomasnorre
Copy link
Contributor Author

Thanks again for the contribution! [joke] I wonder how much you could do if you actually had time to add an exercise every two weeks [/joke].

haha.. As said in the forum multiple times, personal reasons. Perhaps I will tell you about it, some day, but not in public. :)

@tomasnorre tomasnorre requested a review from mk-mxp February 22, 2024 18:58
mk-mxp
mk-mxp approved these changes Feb 22, 2024
View reviewed changes
Copy link
Contributor

@mk-mxp mk-mxp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again very nice exercise! 👏

@mk-mxp mk-mxp merged commit 199cc03 into exercism:main Feb 22, 2024
12 checks passed
@tomasnorre tomasnorre deleted the add-kindergarten-garden-exercise branch February 22, 2024 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mk-mxp mk-mxp mk-mxp approved these changes

Assignees

@tomasnorre tomasnorre

Labels
x:action/create Work on something from scratch x:knowledge/elementary Little Exercism knowledge required x:module/practice-exercise Work on Practice Exercises x:rep/large Large amount of reputation x:size/large Large amount of work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tomasnorre @mk-mxp