Sync: Two Bucket

[tomasnorre]

Resolves: #807

I have added the "setup" to each function, but there are still some diffs, to the arrange, act, assert.

Which one do you prefer? or do we go for a 3rd option?

One:

public function testMeasureUsingBucketOneOfSize3AndBucketTwoOfSize5StartWithBucketOne(): void
{
    $buckOne = 3;
    $buckTwo = 5;
    $goal = 1;
    $starterBuck = 'one';
 
    $subject = new TwoBucket();
    $solution = $subject->solve($buckOne, $buckTwo, $goal, $starterBuck);
 
    $this->assertEquals(4, $solution->numberOfActions);
    $this->assertEquals('one', $solution->nameOfBucketWithDesiredLiters);
    $this->assertEquals(5, $solution->litersLeftInOtherBucket);
}

Two:

public function testMeasureOneStepUsingBucketOneOfSize1AndBucketTwoOfSize3StartWithBucketTwo(): void
{
    $subject = new TwoBucket();
    $solution = $subject->solve(1, 3, 3, 'two');

    $this->assertEquals(1, $solution->numberOfActions);
    $this->assertEquals('two', $solution->nameOfBucketWithDesiredLiters);
    $this->assertEquals(0, $solution->litersLeftInOtherBucket);
}

As there are 3 assertions, I don't know if you prefer having

$expectedNumberOfActions = 1;
$expectedBucketName = 'two';
$expectedLitersInOtherBucket = 0;

Or keep the assertions as is.

[github-actions]

This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested.

If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos.

[no important files changed]

For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping @exercism/maintainers-admin in a comment. Thank you!

[mk-mxp]

Wow, thank you for your quick action!

I'd go with option 2, without extra expected variables. We currently have a mix of both input options, and all input parameters are short enough to easily fit into one line. Same for the output, using variables or an array doesn't make it better.

[mk-mxp]

Thanks a lot for your contribution!