-
-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Various spellchecks #835
Conversation
This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested. If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos.
For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping |
[no important files changed]
14f20d4
to
589b51d
Compare
Thanks for you PR. As a lot of the spelling that you have correct come from https://github.com/exercism/problem-specifications , it would be great if you could create a PR against, that repository too. This will make sure that all tracks on exercism.org will profit from this change next time their exercises gets synced. This PR changes the API of some exercises, which will result in already completed exercises will fail. Therefor this can in my opinion not be merged, sorry. @mk-mxp, @neenjaw or @homersimpsons please way in here. |
Looking at the changes it seems that only the (I'm on mobile so maybe I didn't see another change) About the suggestion to update problem-specifications repository I agree with that if those typos are there too. |
I think you're right, I overlooked that the only changes done was in PHP was the test file. Shouldn't break anything. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for these corrections! Just one small change required, where Search&Replace seems to have gone too far.
exercises/practice/protein-translation/ProteinTranslationTest.php
Outdated
Show resolved
Hide resolved
exercises/practice/protein-translation/ProteinTranslationTest.php
Outdated
Show resolved
Hide resolved
Co-authored-by: mk-mxp <55182845+mk-mxp@users.noreply.github.com>
Thank you all for your comments and careful consideration, and thank you Tomas for the patch! p.s. It'll take some time to grok |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks everyone for contributing!
I used various automated tools to determine mostly orthographic errors, but I edited whatever errors I could find.
I manually fixed everything (no automated edits).
I'm thinking that the "translater" change was an overkill, but I wanted to be pedantic.
edit: I added the "[no important files changed]" bit in the commit message