Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ECR-2364] update dependencies #44

Merged
merged 1 commit into from
Sep 13, 2018
Merged

[ECR-2364] update dependencies #44

merged 1 commit into from
Sep 13, 2018

Conversation

qvantor
Copy link
Contributor

@qvantor qvantor commented Sep 12, 2018

cryptiles < 4.1.2 defined in package-lock.json - not critical for us for now, because it's devDependencies from
karma-sauce-launcher@1.2.0 -> wd@1.10.1 -> request@2.85.0 -> hawk@6.0.2 -> cryptiles@3.1.2, which is used only for local tests start.

When all dependency will be updated, we definitely should fix this vulnerability.
NPM audit found 2 moderate vulnerabilities in rollup-plugin-node-builtins.
For this vulnerabilities created issue: calvinmetcalf/rollup-plugin-node-builtins#42, and we have to wait when it will be fixed.

@coveralls
Copy link

coveralls commented Sep 12, 2018

Coverage Status

Coverage remained the same at 91.176% when pulling a6c3f47 on ECR-2364_dependencies into 1e2c5ab on master.

@qvantor qvantor requested a review from boguslavsky September 12, 2018 10:01
@qvantor qvantor force-pushed the ECR-2364_dependencies branch from 33e295e to a6c3f47 Compare September 13, 2018 09:16
@qvantor qvantor merged commit 00019b4 into master Sep 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants