Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New functionality for giphy input and display #127

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

fred-bowker
Copy link

No description provided.

tabBar.frame.size.height
}
}

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one of the requirements for getting your app approved to use the giphySDK is that you show an attribution mark. This requirement is not very well specified on the giphy sdk docs, however including this small image overlay on the picker meets the requirement

if let giphyKey = giphyConfig.giphyKey {
if !giphyConfigured {
giphyConfigured = true
Giphy.configure(apiKey: giphyKey)
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this line does the auth with the giphy api, you need to have been given an api key from the sdk team first

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have added this as a png instead of pdf, the sticker images is found on https://icon-sets.iconify.design/?query=Sticker fluent:sticker-24-regular

@@ -64,60 +66,53 @@ public enum InputViewState {
}

public enum AvailableInputType {
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rather than now take in textAndAudio textAndMedia, the setInputTypes takes in an array of inputType, this is because you now have 4 different permutations of input type text, media, audio and giphy. Taking in an array is preferable to having textAndAudioAndGiphy textAndAudio etc

.product(name: "ActivityIndicatorView", package: "ActivityIndicatorView")
]
.product(name: "ActivityIndicatorView", package: "ActivityIndicatorView"),
.product(name: "GiphyUISDK", package: "giphy-ios-sdk")
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 2 main options for gif 3rd party API are Tenor and Giphy. Tenor is owned by google, whatsapp is owned by Meta. The Giphy API works well is free and is used in WhatsApp so I chose to use Giphy for the sticker / gif input

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant