-
Notifications
You must be signed in to change notification settings - Fork 305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Py] - Print root module and module function comments #4027
[Py] - Print root module and module function comments #4027
Conversation
It's soooooo nice to see you here again. Warmest regards. I hope you're doing well wherever you are. |
I'm very glad to hear from you again, @alfonsogarciacaro, I hope all is well with you and best wishes! This looks good, just needs the linting ( |
Hello @alfonsogarciacaro, glad to hear from you. Tips if you run |
5b6e018
to
b152c20
Compare
👋 Glad good to see you again! @alfonsogarciacaro |
Perhaps we could retain the comments for every module, instead of just the root module, with a slight update to the Fable AST: type ModuleDecl =
{
Name: string
Entity: EntityRef
Members: Declaration list
XmlDoc: string option // <--- new optional property
} It is an optional property so it shouldn't be technically a breaking change. |
Thank you @pkese, @ncave, @MangelMaxime, @TheAngryByrd for the warm welcome ❤️ ...and for accepting the PR. @MangelMaxime @ncave |
Hey there! Cool project ;)
Just a small PR to print root module and module function comments in Python so the linter stops complaining.
Example:
becomes:
I had to modify the signature of
FSharp2Fable.fsi
and theCompiler
interface, I hope that's ok, but let me know if another way is preferred.Cheers!