Enable configuration of whether quotes are used in generated yaml #6773
+127
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: MichaelMorris <michael.morris@est.tech>
MichaelMorrisEst
requested review from
andreaTP,
metacosm,
manusa,
oscerd,
rohanKanojia and
shawkins
as code owners
Signed-off-by: MichaelMorris <michael.morris@est.tech>
Signed-off-by: MichaelMorris <michael.morris@est.tech>
|
|
Thx for looking into this. @baloo42 do you want to provide feedback? |
shawkins
reviewed
Jan 10, 2025
| * @param <T> the type of the object being serialized. | ||
| * @return a String containing a JSON representation of the provided object. | ||
| */ | ||
| public <T> String asYaml(T object, boolean minQuotes) { |
There was a problem hiding this comment.
I think this change looks good, but wanted to bring up that based upon the DumpSettings there's a lot that could be overriden about the generation style.
Min quoting is roughly defaultScalarStyle=ScalarStyle.PLAIN - it's just that we need to still quote keys that look like boolean values to kube. Another possibliity is to create our own "DumpSettings" builder and have that as an argument so that this can be expanded in the future without adding additional signatures to asYaml.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Enables configuration of whether quotes are included in yaml generated by the KubernetesSerialization class and exposes that through the CRD generator MOJO by adding a new paramater named "minimizeQuotes".
Closes #6763
Type of change
test, version modification, documentation, etc.)
Checklist