-
Notifications
You must be signed in to change notification settings - Fork 235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Copy resources for python_boostrap rules. #676
base: main
Are you sure you want to change the base?
Conversation
Hi @valadez-abel! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
I left some comments on the issues. While I don't fundamentally object to this, I'd like to understand what's different about your RE environment before proceeding |
0485727
to
3ba89d1
Compare
@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
This is an attempt to workaround symbolic link issues with windows remote execution for the python_boostrap_binary rules. With this change, #673, #674, and #675 no longer happen, and C++ compilation properly works.
There's previous art mentioning resources were copied before, in order to keep python happy:
buck2/prelude/filegroup.bzl
Lines 33 to 37 in fdac95c
I'm happy to make any revisions and improve this change.