Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix pam_path variable assignment during build #725

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Atomsoldat
Copy link

@Atomsoldat Atomsoldat commented Jan 28, 2025

It seems that the path for the PAM config file for ly gets determined differently than the other paths. This does not normally cause any problems, because prefixing an empty string to config_directory still results in the correct directory. But it breaks when a non-default dest_directory is used.

Reproduce via:

zig build installsystemd -Ddest_directory='/tmp/debug-ly' && find /tmp/debug-ly

Note the duplicated path:

/tmp/debug-ly
...
/tmp/debug-ly/tmp
/tmp/debug-ly/tmp/debug-ly
/tmp/debug-ly/tmp/debug-ly/etc
/tmp/debug-ly/tmp/debug-ly/etc/pam.d
/tmp/debug-ly/tmp/debug-ly/etc/pam.d/ly

This MR should fix that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant