Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/fix(falco): adding imagePullSecrets at the service account level #811

Closed
wants to merge 2 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions charts/falco/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,10 @@
This file documents all notable changes to Falco Helm Chart. The release
numbering uses [semantic versioning](http://semver.org).

## v4.17.1

* feat/fix(falco): fixing imagePullSecrets(should be an object) + adding it at the SA level

## v4.17.0

* update(falco): bump k8saudit version to 0.11
Expand Down
2 changes: 1 addition & 1 deletion charts/falco/Chart.yaml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
apiVersion: v2
name: falco
version: 4.17.0
version: 4.17.1
appVersion: "0.39.2"
description: Falco
keywords:
Expand Down
1 change: 1 addition & 0 deletions charts/falco/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -782,6 +782,7 @@ The following table lists the main configurable parameters of the falco chart v4
| resources.limits | object | `{"cpu":"1000m","memory":"1024Mi"}` | Maximum amount of resources that Falco container could get. If you are enabling more than one source in falco, than consider to increase the cpu limits. |
| resources.requests | object | `{"cpu":"100m","memory":"512Mi"}` | Although resources needed are subjective on the actual workload we provide a sane defaults ones. If you have more questions or concerns, please refer to #falco slack channel for more info about it. |
| scc.create | bool | `true` | Create OpenShift's Security Context Constraint. |
| serviceAccount.imagePullSecrets | object | `{}` | Secrets containing credentials when pulling from private/secure registries using the service account. |
| serviceAccount.annotations | object | `{}` | Annotations to add to the service account. |
| serviceAccount.create | bool | `true` | Specifies whether a service account should be created. |
| serviceAccount.name | string | `""` | The name of the service account to use. If not set and create is true, a name is generated using the fullname template |
Expand Down
4 changes: 4 additions & 0 deletions charts/falco/templates/serviceaccount.yaml
Original file line number Diff line number Diff line change
@@ -1,6 +1,10 @@

{{- if .Values.serviceAccount.create -}}
apiVersion: v1
{{- with .Values.serviceAccount.imagePullSecrets }}
imagePullSecrets:
{{- toYaml . | nindent 2 }}
{{- end }}
kind: ServiceAccount
metadata:
name: {{ include "falco.serviceAccountName" . }}
Expand Down
2 changes: 2 additions & 0 deletions charts/falco/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,8 @@ namespaceOverride: ""
podAnnotations: {}

serviceAccount:
# -- Secrets containing credentials when pulling from private/secure registries.
imagePullSecrets: []
# -- Specifies whether a service account should be created.
create: true
# -- Annotations to add to the service account.
Expand Down