Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix missing metrics for notifications #535

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

Issif
Copy link
Member

@Issif Issif commented Dec 4, 2024

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup
/kind design
/kind documentation
/kind enhancement
/kind failing-test
/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area actionners
/area build
/area config
/area context
/area core
/area notifiers
/area ouputs
/area rule-engine

What this PR does / Why we need it:

The metric falcosecurity_falco_notifications_total wasn't increased

How to reproduce the issue:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Signed-off-by: Thomas Labarussias <issif+github@gadz.org>
@Issif Issif force-pushed the fix/mising-metrics-notifications branch from 961638c to a66c7de Compare December 9, 2024 18:17
Copy link
Collaborator

@IgorEulalio IgorEulalio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@poiana
Copy link

poiana commented Dec 9, 2024

LGTM label has been added.

Git tree hash: 26795cd1fa1fbf796ca00b2781aafb27422c738e

@poiana
Copy link

poiana commented Dec 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: IgorEulalio, Issif

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit 1903720 into main Dec 9, 2024
4 checks passed
@poiana poiana deleted the fix/mising-metrics-notifications branch December 9, 2024 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants