Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): fixed reusable_build/publish_docker workflows. #3459

Merged
merged 1 commit into from
Jan 21, 2025

Conversation

FedeDP
Copy link
Contributor

@FedeDP FedeDP commented Jan 21, 2025

What type of PR is this?

/kind bug

Any specific area of the project related to this PR?

/area CI

What this PR does / why we need it:

upload-artifact action since v4 does not allow to upload same artifact name multiple times: https://github.com/actions/upload-artifact?tab=readme-ov-file#breaking-changes

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

`upload-artifact` action since v4 does not allow to upload same artifact name multiple times.

Signed-off-by: Federico Di Pierro <nierro92@gmail.com>
@poiana
Copy link
Contributor

poiana commented Jan 21, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FedeDP

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana requested review from Andreagit97 and Kaizhe January 21, 2025 09:57
@FedeDP
Copy link
Contributor Author

FedeDP commented Jan 21, 2025

/milestone 0.40.0

@poiana poiana added this to the 0.40.0 milestone Jan 21, 2025
@poiana poiana added the size/S label Jan 21, 2025
@FedeDP
Copy link
Contributor Author

FedeDP commented Jan 21, 2025

/milestone 0.40.0

@poiana poiana merged commit aba535b into master Jan 21, 2025
33 checks passed
@poiana poiana deleted the fix/build_publish_docker_images branch January 21, 2025 10:38
@FedeDP FedeDP mentioned this pull request Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants