Update handlers to match stats_prometheus.go #1110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
falcosecurity#1051 updated stats_prometheus.go to replace `.` for `_`, but the code that then adds the labels to every instance did not update it, so instances where CUSTOM_FIELDS is set to use a key with `.`s leads to panics. Signed-off-by: Rubens Farias <rubens.mbfarias@gmail.com>
|
Welcome @rubensf! It looks like this is your first PR to falcosecurity/falcosidekick 🎉 |
|
LGTM label has been added. Git tree hash: 8a0afd3a68c4cd24adb37f6fbab0b6c9a26d2492
|
|
The CI fails: |
|
@Issif sorry - I was lazy and didn't even run the tests. Fixed now! But I think CI won't auto-run |
Issif
approved these changes
Jan 31, 2025
|
LGTM label has been added. Git tree hash: 66da29065a3f1dd51882291472b68b5f48c6847b
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Issif, rubensf The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
Any specific area of the project related to this PR?
What this PR does / why we need it: #1051 updated stats_prometheus.go to replace
.for_, but the code that then adds the labels to every instance did not update it, so instances where CUSTOM_FIELDS is set to use a key with.s leads to panics.Which issue(s) this PR fixes: No Github Issue existing so far.
Fixes #
Special notes for your reviewer: