-
-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(plugin_resolve): duplicated querystring on external #2057
base: main
Are you sure you want to change the base?
fix(plugin_resolve): duplicated querystring on external #2057
Conversation
🦋 Changeset detectedLatest commit: b9eec4d The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
CodSpeed Performance ReportMerging #2057 will create unknown performance changesComparing Summary
|
thanks |
@@ -83,7 +83,7 @@ impl Plugin for FarmPluginResolve { | |||
// check external first, if the source is set as external, return it immediately | |||
if external_config.is_external(source) { | |||
return Ok(Some(PluginResolveHookResult { | |||
resolved_path: param.source.clone(), | |||
resolved_path: String::from(source), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you should remove remove querystring ?xxx
from param.source
to resolve this issue
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The querystring is removed at line 63:
// split query from source
let splits: Vec<&str> = source.split('?').collect();
let source = splits[0];
But the param.source
remains untouched.
So I have changed param.source
into the source
, which querystring is removed.
Description:
import { Astal } from 'gi://Astal?version=4.0
['^gi://']
import { o } from "gi://Astal?version=4.0?version=4.0";
Reproduction: