Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

break: rename default to fallbackValue for clarity #2026

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

abvthecity
Copy link
Contributor

based on feedback from launchdarkly the terminology is clearer to say "fallbackValue" than "default".

https://docs.launchdarkly.com/home/getting-started/vocabulary#fallback-value

@abvthecity abvthecity marked this pull request as ready for review January 15, 2025 18:42
Copy link

vercel bot commented Jan 15, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
rbac.ferndocs.com ❌ Failed (Inspect) Jan 15, 2025 6:42pm
1 Skipped Deployment
Name Status Preview Updated (UTC)
fern-shell ⬜️ Ignored (Inspect) Jan 15, 2025 6:42pm

Copy link

Copy link

📦 Next.js Bundle Analysis for fern-platform-monorepo

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

Copy link

PR Preview

Copy link

Playwright test results

passed  99 passed
skipped  2 skipped

Details

stats  101 tests across 9 suites
duration  1 minute, 1 second
commit  7b748fc

Skipped tests

chromium › posthog.spec.ts › Posthog loads successfully
chromium › websockets/websocket.spec.ts › websocket test

@abvthecity abvthecity merged commit 63b7b6e into main Jan 15, 2025
17 of 19 checks passed
@abvthecity abvthecity deleted the ajiang/ld-fallback-value branch January 15, 2025 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants