Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: hide filesv2 from static props #2044

Merged
merged 14 commits into from
Jan 23, 2025
Merged

refactor: hide filesv2 from static props #2044

merged 14 commits into from
Jan 23, 2025

Conversation

abvthecity
Copy link
Contributor

@abvthecity abvthecity commented Jan 21, 2025

in order to support S3'ifying all markdown files, we need to remove filesV2 from being streamed to the frontend.

before this pr, the files record is passed to the client-side and injected at runtime. after this pr, the files record is used to resolve file references on the server side.

this PR affects:

Copy link

vercel bot commented Jan 21, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
rbac.ferndocs.com ❌ Failed (Inspect) Jan 21, 2025 11:29pm
1 Skipped Deployment
Name Status Preview Updated (UTC)
fern-shell ⬜️ Ignored (Inspect) Jan 21, 2025 11:29pm

@abvthecity abvthecity had a problem deploying to Preview - app-dev.buildwithfern.com January 21, 2025 23:29 — with GitHub Actions Failure
@abvthecity abvthecity had a problem deploying to Preview - app.buildwithfern.com January 21, 2025 23:29 — with GitHub Actions Failure
@abvthecity abvthecity marked this pull request as ready for review January 21, 2025 23:38
@abvthecity abvthecity requested a review from dsinghvi as a code owner January 21, 2025 23:38
@abvthecity abvthecity enabled auto-merge (squash) January 21, 2025 23:38
@abvthecity abvthecity disabled auto-merge January 21, 2025 23:39
// "light" in logo &&
// "dark" in logo &&
// isFileIdOrUrl(logo.light) &&
// isFileIdOrUrl(logo.dark)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still working on a new home for this logic

Copy link
Member

@dsinghvi dsinghvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

Copy link

📦 Next.js Bundle Analysis for fern-platform-monorepo

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

Copy link

PR Preview

@abvthecity abvthecity merged commit 705e1d5 into main Jan 23, 2025
16 of 19 checks passed
@abvthecity abvthecity deleted the ajiang/remove-files branch January 23, 2025 00:58
Copy link

Playwright test results

failed  1 failed
passed  89 passed
flaky  1 flaky
skipped  10 skipped

Details

stats  101 tests across 9 suites
duration  1 minute, 32 seconds
commit  dffb13c

Failed tests

chromium › forward-proxy/express.spec.ts › home page 404

Flaky tests

chromium › smoke/favicon.spec.ts › Check if favicon exists and URL does not return 404 for api.labelstud.io

Skipped tests

chromium › forward-proxy/express.spec.ts › capture the flag
chromium › forward-proxy/express.spec.ts › redirect
chromium › forward-proxy/express.spec.ts › 404
chromium › forward-proxy/express.spec.ts › sitemap.xml
chromium › forward-proxy/express.spec.ts › revalidate-all/v3 all should work
chromium › forward-proxy/express.spec.ts › revalidate-all/v3 should work with trailing slash
chromium › forward-proxy/express.spec.ts › revalidate-all/v4 should work
chromium › forward-proxy/express.spec.ts › revalidate-all/v4 should work with trailing slash
chromium › posthog.spec.ts › Posthog loads successfully
chromium › websockets/websocket.spec.ts › websocket test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants