Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: run search/v1/apikey in node #2085

Merged
merged 1 commit into from
Jan 25, 2025

Conversation

dsinghvi
Copy link
Member

Short description of the changes made

Run the search/v1/key route in nodejs. Load with URL from S3 uses crypto which is not vercel edge friendly.

What was the motivation & context behind this PR?

Seeing 1k+ failures in search/v1/key.

How has this PR been tested?

Previews

@dsinghvi dsinghvi marked this pull request as ready for review January 25, 2025 20:15
@dsinghvi dsinghvi requested a review from abvthecity as a code owner January 25, 2025 20:15
Copy link

vercel bot commented Jan 25, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
rbac.ferndocs.com ❌ Failed (Inspect) Jan 25, 2025 8:15pm
1 Skipped Deployment
Name Status Preview Updated (UTC)
fern-shell ⬜️ Ignored (Inspect) Jan 25, 2025 8:15pm

Copy link

📦 Next.js Bundle Analysis for fern-platform-monorepo

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

Copy link

PR Preview

@dsinghvi dsinghvi merged commit fbdea4b into main Jan 25, 2025
16 of 17 checks passed
@dsinghvi dsinghvi deleted the dsinghvi/search-v1-key-should-run-in-node branch January 25, 2025 20:25
Copy link

Playwright test results

passed  95 passed
skipped  2 skipped

Details

stats  97 tests across 9 suites
duration  54.6 seconds
commit  4f37890

Skipped tests

chromium › posthog.spec.ts › Posthog loads successfully
chromium › websockets/websocket.spec.ts › websocket test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant