Skip to content

Commit

Permalink
fix(cli): override whatwg-url to eliminate punycode deprecation warni…
Browse files Browse the repository at this point in the history
…ng (#5811)
  • Loading branch information
zachkirsch authored Jan 31, 2025
1 parent 741c99f commit b91dafe
Show file tree
Hide file tree
Showing 5 changed files with 24 additions and 22 deletions.
7 changes: 6 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -125,5 +125,10 @@
"!packages/cli/cli/dist/local",
"!packages/cli/cli/dist/dev",
"!packages/cli/cli/dist/prod"
]
],
"pnpm": {
"overrides": {
"node-fetch@2.x>whatwg-url": "^14.0.0"

This comment has been minimized.

Copy link
@abvthecity

abvthecity Jan 31, 2025

Contributor

love this

}
}
}
3 changes: 1 addition & 2 deletions packages/cli/cli/build.dev.cjs
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,7 @@ async function main() {
version: process.argv[2] || packageJson.version,
repository: packageJson.repository,
files: ["cli.cjs"],
bin: { "fern-dev": "cli.cjs" },
noExternal: ['punycode']
bin: { "fern-dev": "cli.cjs" }
},
undefined,
2
Expand Down
1 change: 0 additions & 1 deletion packages/cli/cli/build.local.cjs
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ async function main() {
format: ['cjs'],
minify: false,
outDir: 'dist/local',
noExternal: ['punycode'],
env: {
AUTH0_DOMAIN: "fern-dev.us.auth0.com",
AUTH0_CLIENT_ID: "4QiMvRvRUYpnycrVDK2M59hhJ6kcHYFQ",
Expand Down
1 change: 0 additions & 1 deletion packages/cli/cli/build.prod.cjs
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ async function main() {
format: ['cjs'],
minify: true,
outDir: 'dist/prod',
noExternal: ['punycode'],
env: {
AUTH0_DOMAIN: "fern-prod.us.auth0.com",
AUTH0_CLIENT_ID: "syaWnk6SjNoo5xBf1omfvziU3q7085lh",
Expand Down
34 changes: 17 additions & 17 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit b91dafe

Please sign in to comment.