fix(typescript): Don't double wrap a blob if a user uploads a blob to…

… a multi-part form. (#5776) fix(typescript): Don't double wrap a blob if a user uploads a blob to a multi-part form.
fern-api · Jan 29, 2025 · ebb97be · ebb97be
1 parent 53ed96d
commit ebb97be
Show file tree

Hide file tree

Showing 21 changed files with 64 additions and 33 deletions.
diff --git a/generators/typescript/sdk/CHANGELOG.md b/generators/typescript/sdk/CHANGELOG.md
@@ -5,6 +5,11 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [0.48.5] - 2025-01-28
+
+- Fix: Don't double wrap a blob if a user uploads a blob to a multi-part form.
+  Otherwise file's content-type is lost in Deno.
+
 ## [0.48.4] - 2025-01-21
 
 - Fix: When custom config `useBigInt` is `true`, generate examples and snippets with `BigInt("123")`.

diff --git a/generators/typescript/sdk/VERSION b/generators/typescript/sdk/VERSION
@@ -1 +1 @@
-0.48.4
+0.48.5
diff --git a/generators/typescript/utils/core-utilities/fetcher/src/form-data-utils/FormDataWrapper.ts b/generators/typescript/utils/core-utilities/fetcher/src/form-data-utils/FormDataWrapper.ts
@@ -165,6 +165,10 @@ export class WebFormData implements CrossPlatformFormData {
         if (fileName == null && isNamedValue(value)) {
             fileName = value.name;
         }
+        if (value instanceof Blob) {
+            this.fd?.append(key, value, fileName);
+            return;
+        }
         this.fd?.append(key, new Blob([value]), fileName);
     }
 

diff --git a/packages/cli/ete-tests/src/tests/dependencies/__snapshots__/dependencies.test.ts.snap b/packages/cli/ete-tests/src/tests/dependencies/__snapshots__/dependencies.test.ts.snap
diff --git a/packages/cli/ete-tests/src/tests/help/__snapshots__/help.test.ts.snap b/packages/cli/ete-tests/src/tests/help/__snapshots__/help.test.ts.snap
@@ -1,7 +1,9 @@
 // Vitest Snapshot v1, https://vitest.dev/guide/snapshot.html
 
 exports[`help > no arguments 1`] = `
-"fern-dev
+"(node:20167) [DEP0040] DeprecationWarning: The \`punycode\` module is deprecated. Please use a userland alternative instead.
+(Use \`node --trace-deprecation ...\` to show where the warning was created)
+fern-dev
 
 Commands:
   fern-dev init                         Initialize a Fern API

diff --git a/packages/cli/ete-tests/src/tests/jsonschema/__snapshots__/jsonschema.test.ts.snap b/packages/cli/ete-tests/src/tests/jsonschema/__snapshots__/jsonschema.test.ts.snap
diff --git a/packages/cli/ete-tests/src/tests/write-definition/__snapshots__/writeDefinition.test.ts.snap b/packages/cli/ete-tests/src/tests/write-definition/__snapshots__/writeDefinition.test.ts.snap
@@ -71,6 +71,7 @@ service:
               max: 100
       response:
         docs: A paged array of pets
+        status-code: 200
         type: root.Pets
       source:
         openapi: openapi/openapi.yml
@@ -93,6 +94,7 @@ service:
           type: string
       response:
         docs: Expected response to a valid request
+        status-code: 200
         type: root.Pet
       source:
         openapi: openapi/openapi.yml
@@ -178,6 +180,7 @@ service:
               max: 100
       response:
         docs: A paged array of pets
+        status-code: 200
         type: root.Pets
       source:
         openapi: openapi/openapi.yml
@@ -200,6 +203,7 @@ service:
           type: string
       response:
         docs: Expected response to a valid request
+        status-code: 200
         type: root.Pet
       source:
         openapi: openapi/openapi.yml
@@ -316,6 +320,7 @@ service:
               max: 100
       response:
         docs: A paged array of pets
+        status-code: 200
         type: neopetsRoot.Pets
       source:
         openapi: openapi/petstore/openapi.yml
@@ -340,6 +345,7 @@ service:
           type: string
       response:
         docs: Expected response to a valid request
+        status-code: 200
         type: neopetsRoot.Pet
       source:
         openapi: openapi/petstore/openapi.yml
@@ -979,6 +985,7 @@ service:
         content-type: application/json
       response:
         docs: Booking successful
+        status-code: 201
         type: CreateBookingResponse
       source:
         openapi: openapi/trains/openapi.yml
@@ -1036,6 +1043,7 @@ service:
           type: string
       response:
         docs: The booking details
+        status-code: 200
         type: GetBookingResponse
       source:
         openapi: openapi/trains/openapi.yml
@@ -1071,6 +1079,7 @@ service:
       path: /bookings
       response:
         docs: A list of bookings
+        status-code: 200
         type: GetBookingsResponse
       source:
         openapi: openapi/trains/openapi.yml
@@ -1275,6 +1284,7 @@ service:
         content-type: application/json
       response:
         docs: Payment successful
+        status-code: 200
         type: CreateBookingPaymentResponse
       source:
         openapi: openapi/trains/openapi.yml
@@ -1348,6 +1358,7 @@ service:
       path: /stations
       response:
         docs: A list of train stations
+        status-code: 200
         type: GetStationsResponse
       source:
         openapi: openapi/trains/openapi.yml
@@ -1500,6 +1511,7 @@ service:
               format: uuid
       response:
         docs: A list of available train trips
+        status-code: 200
         type: GetTripsResponse
       source:
         openapi: openapi/trains/openapi.yml
@@ -1992,6 +2004,7 @@ service:
         name: ChatRequest
       response:
         docs: OK
+        status-code: 200
         type: list<string>
       source:
         openapi: openapi/cohere.yaml
@@ -2315,6 +2328,7 @@ service:
         name: V2ChatRequest
       response:
         docs: OK
+        status-code: 200
         type: list<string>
       source:
         openapi: openapi/cohere-v2.yaml

diff --git a/.../ete-tests/src/tests/write-definition/fixtures/header-overrides/fern/.definition/pets.yml b/.../ete-tests/src/tests/write-definition/fixtures/header-overrides/fern/.definition/pets.yml
@@ -34,6 +34,7 @@ service:
               max: 100
       response:
         docs: A paged array of pets
+        status-code: 200
         type: root.Pets
       source:
         openapi: openapi/openapi.yml
@@ -56,6 +57,7 @@ service:
           type: string
       response:
         docs: Expected response to a valid request
+        status-code: 200
         type: root.Pet
       source:
         openapi: openapi/openapi.yml

diff --git a/...tests/write-definition/fixtures/namespaced-fleshedout/fern/.definition/v1/__package__.yml b/...tests/write-definition/fixtures/namespaced-fleshedout/fern/.definition/v1/__package__.yml
@@ -445,6 +445,7 @@ service:
         name: ChatRequest
       response:
         docs: OK
+        status-code: 200
         type: list<string>
       source:
         openapi: openapi/cohere.yaml

diff --git a/...ests/src/tests/write-definition/fixtures/namespaced-fleshedout/fern/.definition/v2/v2.yml b/...ests/src/tests/write-definition/fixtures/namespaced-fleshedout/fern/.definition/v2/v2.yml
@@ -133,6 +133,7 @@ service:
         name: V2ChatRequest
       response:
         docs: OK
+        status-code: 200
         type: list<string>
       source:
         openapi: openapi/cohere-v2.yaml

diff --git a/...te-tests/src/tests/write-definition/fixtures/namespaced/fern/.definition/neopets/pets.yml b/...te-tests/src/tests/write-definition/fixtures/namespaced/fern/.definition/neopets/pets.yml
@@ -36,6 +36,7 @@ service:
               max: 100
       response:
         docs: A paged array of pets
+        status-code: 200
         type: neopetsRoot.Pets
       source:
         openapi: openapi/petstore/openapi.yml
@@ -60,6 +61,7 @@ service:
           type: string
       response:
         docs: Expected response to a valid request
+        status-code: 200
         type: neopetsRoot.Pet
       source:
         openapi: openapi/petstore/openapi.yml

diff --git a/...tests/src/tests/write-definition/fixtures/namespaced/fern/.definition/trains/bookings.yml b/...tests/src/tests/write-definition/fixtures/namespaced/fern/.definition/trains/bookings.yml
@@ -69,6 +69,7 @@ service:
         content-type: application/json
       response:
         docs: Booking successful
+        status-code: 201
         type: CreateBookingResponse
       source:
         openapi: openapi/trains/openapi.yml
@@ -126,6 +127,7 @@ service:
           type: string
       response:
         docs: The booking details
+        status-code: 200
         type: GetBookingResponse
       source:
         openapi: openapi/trains/openapi.yml
@@ -161,6 +163,7 @@ service:
       path: /bookings
       response:
         docs: A list of bookings
+        status-code: 200
         type: GetBookingsResponse
       source:
         openapi: openapi/trains/openapi.yml

diff --git a/...tests/src/tests/write-definition/fixtures/namespaced/fern/.definition/trains/payments.yml b/...tests/src/tests/write-definition/fixtures/namespaced/fern/.definition/trains/payments.yml
@@ -192,6 +192,7 @@ service:
         content-type: application/json
       response:
         docs: Payment successful
+        status-code: 200
         type: CreateBookingPaymentResponse
       source:
         openapi: openapi/trains/openapi.yml

diff --git a/...tests/src/tests/write-definition/fixtures/namespaced/fern/.definition/trains/stations.yml b/...tests/src/tests/write-definition/fixtures/namespaced/fern/.definition/trains/stations.yml
@@ -61,6 +61,7 @@ service:
       path: /stations
       response:
         docs: A list of train stations
+        status-code: 200
         type: GetStationsResponse
       source:
         openapi: openapi/trains/openapi.yml

diff --git a/...te-tests/src/tests/write-definition/fixtures/namespaced/fern/.definition/trains/trips.yml b/...te-tests/src/tests/write-definition/fixtures/namespaced/fern/.definition/trains/trips.yml
@@ -98,6 +98,7 @@ service:
               format: uuid
       response:
         docs: A list of available train trips
+        status-code: 200
         type: GetTripsResponse
       source:
         openapi: openapi/trains/openapi.yml

diff --git a/...ages/cli/ete-tests/src/tests/write-definition/fixtures/petstore/fern/.definition/pets.yml b/...ages/cli/ete-tests/src/tests/write-definition/fixtures/petstore/fern/.definition/pets.yml
@@ -34,6 +34,7 @@ service:
               max: 100
       response:
         docs: A paged array of pets
+        status-code: 200
         type: root.Pets
       source:
         openapi: openapi/openapi.yml
@@ -56,6 +57,7 @@ service:
           type: string
       response:
         docs: Expected response to a valid request
+        status-code: 200
         type: root.Pet
       source:
         openapi: openapi/openapi.yml

diff --git a/...register/src/ir-to-fdr-converter/__test__/__snapshots__/csharp-grpc-proto-exhaustive.json b/...register/src/ir-to-fdr-converter/__test__/__snapshots__/csharp-grpc-proto-exhaustive.json
@@ -712,7 +712,8 @@
                   "type": "unknown"
                 }
               }
-            }
+            },
+            "statusCode": 200
           },
           "errorsV2": [],
           "examples": [
@@ -804,6 +805,7 @@
                 "value": "type_:UploadResponse"
               }
             },
+            "statusCode": 200,
             "description": "OK"
           },
           "errorsV2": [],
@@ -946,6 +948,7 @@
                 "value": "type_:DeleteResponse"
               }
             },
+            "statusCode": 200,
             "description": "OK"
           },
           "errorsV2": [],
@@ -1027,6 +1030,7 @@
                 "value": "type_:DescribeResponse"
               }
             },
+            "statusCode": 200,
             "description": "OK"
           },
           "errorsV2": [],
@@ -1129,6 +1133,7 @@
                 "value": "type_:FetchResponse"
               }
             },
+            "statusCode": 200,
             "description": "OK"
           },
           "errorsV2": [],
@@ -1280,6 +1285,7 @@
                 "value": "type_:ListResponse"
               }
             },
+            "statusCode": 200,
             "description": "OK"
           },
           "errorsV2": [],
@@ -1477,6 +1483,7 @@
                 "value": "type_:QueryResponse"
               }
             },
+            "statusCode": 200,
             "description": "OK"
           },
           "errorsV2": [],
@@ -1678,6 +1685,7 @@
                 "value": "type_:UpdateResponse"
               }
             },
+            "statusCode": 200,
             "description": "OK"
           },
           "errorsV2": [],

diff --git a/packages/cli/register/src/ir-to-fdr-converter/__test__/__snapshots__/csharp-grpc-proto.json b/packages/cli/register/src/ir-to-fdr-converter/__test__/__snapshots__/csharp-grpc-proto.json
@@ -261,6 +261,7 @@
                 "value": "type_:CreateResponse"
               }
             },
+            "statusCode": 200,
             "description": "OK"
           },
           "errorsV2": [],

diff --git a/seed/ts-sdk/file-upload/inline/src/core/form-data-utils/FormDataWrapper.ts b/seed/ts-sdk/file-upload/inline/src/core/form-data-utils/FormDataWrapper.ts
diff --git a/seed/ts-sdk/file-upload/no-custom-config/src/core/form-data-utils/FormDataWrapper.ts b/seed/ts-sdk/file-upload/no-custom-config/src/core/form-data-utils/FormDataWrapper.ts
diff --git a/seed/ts-sdk/file-upload/no-serde/src/core/form-data-utils/FormDataWrapper.ts b/seed/ts-sdk/file-upload/no-serde/src/core/form-data-utils/FormDataWrapper.ts