-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DNM] feat(docs): turn on http snippets by default #5831
base: main
Are you sure you want to change the base?
Conversation
navigation: | ||
- api: API Reference | ||
snippets: | ||
http: false # <--- disable HTTP snippets; defaults to true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What if the customer wants to customize their own set of httpsnippet targets?
See:
https://github.com/Kong/httpsnippet/tree/master/src/targets
For supported targets.
Ie "I only want to enable python and php"
Or "I want to show php snippets using http2 and guzzle"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good call. added this idea in the latest commit.
what if I want:
- SDK, typescript
- HTTP, javascript fetch
- SDK, python
- HTTP, python requests
my current config doesn't allow this
relevant: fern/packages/cli/configuration/src/docs-yml/ParsedDocsConfiguration.ts Lines 266 to 278 in 05b0e7b
|
this PR proposes:
docs.yml
to turn HTTP snippets offwhen turned on by default, we can delete the edge-config flag for http-snippets.