Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(csharp): Misc improvements #5838

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

chore(csharp): Misc improvements #5838

wants to merge 6 commits into from

Conversation

Swimburger
Copy link
Member

@Swimburger Swimburger commented Feb 3, 2025 •
edited
Loading

Description

Miscellaneous improvement for the C# generator

  • Call .ConfigureAwait(false) on Tasks
  • Use Enumerable<T>.Empty instead of creating a new empty list
  • Add PolySharp to test project and use C# 12
  • Remove redundant #nullable enable directives
  • Use SystemTask alias for System.Threading.Tasks.Task to avoid conflict with potentially named Task resources
  • Improve C# syntax

Testing

  • Seed

@Swimburger
Misc improvement for the C# generator
c05e51c 
- Call `.ConfigureAwait(false)` on Tasks
- Use Enumerable<T>.Empty instead of creating a new empty list
- Add PolySharp to test project and use C# 12
- Improve C# syntax
- Remove redundant `#nullable enable` directives
@Swimburger
Add C# generator version
f9f4dfb
@Swimburger Swimburger requested a review from dsinghvi as a code owner February 3, 2025 02:25
@Swimburger Swimburger changed the title internal(cshvarp): Misc improvements internal(csharp): Misc improvements Feb 3, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 3, 2025 •
edited
Loading

🌿 Preview your docs: https://fern-preview-b2a35cd2-2494-4e19-8479-664517e6c926.docs.buildwithfern.com/learn

@Swimburger Swimburger changed the title internal(csharp): Misc improvements chore(csharp): Misc improvements Feb 3, 2025
amckinney
amckinney approved these changes Feb 3, 2025
View reviewed changes
Copy link
Member

@amckinney amckinney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks great, but a couple test definitions might need some attention (e.g. pagination).

generators/csharp/codegen/src/asIs/test/EnumSerializerTests.Template.cs
"enum_property": "{{KnownEnumValue2String}}"
}
""";
private const string JsonWithKnownEnum2 = $$"""
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this string format preferred? I would have thought the previous nesting was better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amckinney amckinney amckinney approved these changes

@dsinghvi dsinghvi Awaiting requested review from dsinghvi dsinghvi is a code owner

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Swimburger @amckinney