Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

['digest'] issue and ['args'] issue fix #20

Merged
merged 4 commits into from
Sep 30, 2024

Conversation

tanaygodse
Copy link
Contributor

Removed digest from model, hardcoded a value 'nextgen' for now, removed 'args' from the payload value

Proposed Changes

[describe the changes here...]

Linked Issues

#18
#19

Types of changes

What type of change does this pull request make (put an x in the boxes that apply)?

  • Bug fix (non-breaking change that fixes an issue).
  • New feature added (non-breaking change that adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to stop working as expected).
  • Documentation update.
  • Something else (e.g., tests, scripts, example, deployment, infrastructure).

Checklist

Put an x in the boxes that apply:

  • I have read the CONTRIBUTING guide
  • Checks and tests pass locally

If applicable

  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that code coverage does not decrease
  • I have added/updated the documentation

Further comments

@tanaygodse tanaygodse requested a review from qati as a code owner September 18, 2024 18:11
@tanaygodse
Copy link
Contributor Author

@qati Please check

ai_engine_sdk/client.py Outdated Show resolved Hide resolved
@tanaygodse tanaygodse requested a review from qati September 19, 2024 16:57
ai_engine_sdk/client.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@XaviPeiro XaviPeiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, add tests that reflect these fixes.

(For further occasions: let's do that on branches instead of forks, please.)

@tanaygodse
Copy link
Contributor Author

Please, add tests that reflect these fixes.

(For further occasions: let's do that on branches instead of forks, please.)

I followed the instructions on https://github.com/fetchai/ai-engine-sdk-python/blob/master/CONTRIBUTING.md

Will create a branch directly for this repository and try again.

@tanaygodse
Copy link
Contributor Author

@XaviPeiro I tried creating a branch in the main repository instead of fork, got this error:
git push upstream digest-issue
ERROR: Permission to fetchai/ai-engine-sdk-python.git denied to tanaygodse.
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.

I believe I do not have the rights to make changes to the main repository. Let me know what to do.

@XaviPeiro
Copy link
Collaborator

XaviPeiro commented Sep 24, 2024

@XaviPeiro I tried creating a branch in the main repository instead of fork, got this error: git push upstream digest-issue ERROR: Permission to fetchai/ai-engine-sdk-python.git denied to tanaygodse. fatal: Could not read from remote repository.

Please make sure you have the correct access rights and the repository exists.

I believe I do not have the rights to make changes to the main repository. Let me know what to do.

Sure, my bad mate.
Sadly, as for now I cannot do it, I should solve some issues first :(

If you want we can continue on the fork for the moment just to not get stuck.

My apologies for that unfruitful request, @tanaygodse .

ai_engine_sdk/client.py Outdated Show resolved Hide resolved
ai_engine_sdk/client.py Outdated Show resolved Hide resolved
@qati qati merged commit 5295a12 into fetchai:master Sep 30, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants