Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add A image lightbox in imageColumn #9501

Closed
wants to merge 7 commits into from

Conversation

lam0819
Copy link

@lam0819 lam0819 commented Nov 7, 2023

  • Changes have been thoroughly tested to not break existing functionality.
  • New functionality has been documented or existing documentation has been updated to reflect changes.
  • Visual changes are explained in the PR description using a screenshot/recording of before and after.

In this pull request,
Our goal is to introduce a basic image lightbox functionality without incorporating any extra libraries.
For a more sophisticated image lightbox effect or if additional libraries are desired, the use of an additional filament plugin is recommended.
Upon clicking an image within the imageColumn, a lightbox popup will be displayed.
image

@zepfietje
Copy link
Member

Honestly, I think this would be better suited as a plugin.
Also, you could simply attach an action to the column already and have it open a modal that shows the image.

Going to close this, but will notify @danharrin for a final decision.

@zepfietje zepfietje closed this Nov 7, 2023
@zepfietje zepfietje added this to the v3 milestone Nov 7, 2023
@zepfietje zepfietje added the enhancement New feature or request label Nov 7, 2023
@wychoong
Copy link
Contributor

wychoong commented Nov 7, 2023

could simply attach an action to the column already and have it open a modal

would like to see this lightbox implementation in the core, a modal with static content (eg: an image or announcement) without a server request

@lam0819
Copy link
Author

lam0819 commented Nov 8, 2023

ya, my target is simple lightbox in image. for other attachments, eg pdf , i think need additional plugin.

@lam0819
Copy link
Author

lam0819 commented Nov 17, 2023

@wychoong

Since it will not merge into core function, i make a package to do this now.
Keep base on ImageColumn and TextColumn.
Support Image , PDF, Word, PPTX too.

Enjoy

https://github.com/solutionforest/Filament-SimpleLightBox

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants