Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Filament 3.1 news article #270

Merged
merged 5 commits into from
Dec 17, 2023

Conversation

alexandersix
Copy link
Contributor

This PR adds a new article for the release of Filament 3.1 and a new author entry (me!)

Copy link
Member

@saade saade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! Thanks for your contribution. This is a first review that checks if everything is correct and inline with our guidelines. The actual content of your article/ trick needs to be reviewed by another team member before it can be fully merged and published on our website.

@saade saade requested a review from danharrin December 17, 2023 00:07
@saade
Copy link
Member

saade commented Dec 17, 2023

Maybe we can publish this under the filament author? idk what do you guys think? @alexandersix @danharrin

@alexandersix
Copy link
Contributor Author

alexandersix commented Dec 17, 2023

@saade I've personally always liked when updates about a project come from people on the team rather than the project account, but that's all my own preference. I know @danharrin has been the one authoring previous updates, so I feel like keeping with that pattern is probably worthwhile.

@danharrin
Copy link
Member

Yeah using the actual author profile is good for this, as long as the author bio hints that they are officially involved in the Filament team. The official plugins are different as they are contributed to by the community and multiple Filament team members.

@danharrin danharrin merged commit a3e173a into main Dec 17, 2023
1 check passed
@danharrin danharrin deleted the content/add-filament-31-release-article branch December 17, 2023 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

3 participants