Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add video conversion to HTML in Markdown parser #627

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

saade
Copy link
Member

@saade saade commented Jan 6, 2025

This PR updates the markdown parsing to automatically turn specific URLs into <video> tags while ensuring there are no duplicates.

What’s New:

Convert URLs to <video>:

  • Targets URLs like https://github.com/user-attachments/assets/....
  • Replaces unique URLs with a <video> tag containing the proper attributes.
  • Clean Up Duplicates:
    • If the same URL shows up multiple times, it only keeps the first conversion and removes the rest.

@saade saade added the enhancement New feature or request label Jan 6, 2025
@saade saade requested a review from danharrin January 6, 2025 20:06
@saade saade self-assigned this Jan 6, 2025
@danharrin danharrin merged commit 82cd0e4 into main Jan 6, 2025
2 checks passed
@danharrin
Copy link
Member

Thanks!

@danharrin danharrin deleted the feat/convert-assets-to-video-tag branch January 6, 2025 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants