Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add draft status for plugins #628

Merged
merged 3 commits into from
Jan 9, 2025
Merged

feat: add draft status for plugins #628

merged 3 commits into from
Jan 9, 2025

Conversation

saade
Copy link
Member

@saade saade commented Jan 7, 2025

This PR adds an is_draft column to the plugins table. Plugins marked as drafts will no longer appear in the plugin listing on the website. This ensures only non-draft plugins are publicly visible.

@saade saade added the enhancement New feature or request label Jan 7, 2025
@saade saade requested a review from danharrin January 7, 2025 01:02
@danharrin
Copy link
Member

Do these other places also filter out drafts?

  • API plugin list
  • List of "other plugins" from author when viewing a plugin

@saade
Copy link
Member Author

saade commented Jan 7, 2025

I initially added the plugin to the API list, but since it's an API, I thought it would be better to return the plugin with a status of "draft" (as it's just a state of the plugin, not an actual deletion).

As for the "Other Plugins," I realized I missed them and will be adding them shortly.

@saade
Copy link
Member Author

saade commented Jan 7, 2025

@danharrin introduced a filter to the plugin list API. If no filter is provided, the behavior remains unchanged; however, if a filter is specified, the results will be filtered accordingly.

Draft plugins have also been excluded from the "More from this author" section.

@danharrin danharrin merged commit 485b2de into main Jan 9, 2025
1 check passed
@danharrin
Copy link
Member

Thanks

@saade saade deleted the feat/draft-plugins branch January 9, 2025 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants