Db contrib/waltz 6595 bulk taxonomy #7139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- basic parser - stated on service impl #CTCTOWALTZ-3313 finos#6595
- basic parser - stated on service impl #CTCTOWALTZ-3313 finos#6595
- basic parser - stated on service impl #CTCTOWALTZ-3313 finos#6595
- parser (Jackson based) - analysis to diff against current taxonomy - Unit tests for parser - Integration tests for diff #CTCTOWALTZ-3313 finos#6595
- handles REPLACE mode - added id and parent_id as synonyms for external_id and external_parent_id - validation result gives list of measurables it will remove - fixed identification of changed fields #CTCTOWALTZ-3313 finos#6595
- extracted to a new service class (BulkTaxonomyChangeService) - support for applying previewed changes - updated tests #CTCTOWALTZ-3313 finos#6595
- created endpoints for preview and apply - added basic authorization checks - basic ui support TODO: - [ ] rebuild hierarchy (incl setting internal ids) - [ ] refresh ui after load - [ ] removals - [ ] finer grained permissions - [ ] change log entries #CTCTOWALTZ-3313 finos#6595
- restores 'removed' measurables - ignores empty / commented lines - normalised method names - utility methods for streaming lines (+ tests) - ui improvements to show changed fields and _all_ operations TODO: - [ ] rebuild hierarchy (incl setting internal ids) - [ ] feedback for result of the 'apply' step - [ ] refresh ui after load - [ ] removals - [ ] change log entries - [ ] nicer error messages #CTCTOWALTZ-3313 finos#6595
- integration tests for measurable restoration - new support method to allow tests to set the lifecycle phase of measurable - detect whether rebuild is required - reassigned parent ids based on external ids - rebuild entity hierarchy for catergory TODO: - [x] rebuild hierarchy (incl setting internal ids) - [ ] feedback for result of the 'apply' step - [ ] refresh ui after load - [ ] removals - [ ] change log entries - [ ] nicer error messages #CTCTOWALTZ-3313 finos#6595
- improved the help section - feedback for apply step TODO: - [x] feedback for result of the 'apply' step - [ ] refresh ui after load - [ ] removals - [ ] change log entries - [ ] nicer error messages - [ ] add synonyms with spaces #CTCTOWALTZ-3313 finos#6595
- added more synonyms - removed add only and replace buttons - improved styling of help section - parser error messages displayed and prevent apply step if parse failed TODO: - [x] feedback for result of the 'apply' step - [ ] refresh ui after load - [ ] removals - [ ] change log entries - [x] nicer error messages - [x] add synonyms with spaces #CTCTOWALTZ-3313 finos#6595
- the apply step now creates 'fake' TaxonomyChangeRecord entries - removed the default values - reset the maintain screens to default to the interactive editor tab TODO: - [x] change log entries - [x] reset the testing defaults (values and tab selection) #CTCTOWALTZ-3313 finos#6595
#CTCTOWALTZ-3313 finos#6595
Merge in WALTZ/waltz from WALTZ/waltz-dw:CTCTOWALTZ-3313-bulk-taxonomy-6595 to db-feature/waltz-6595-bulk-taxonomy * commit '69bc6681e4a2a7a82cf190919ec419105b8ea4cb': Measurable Taxonomy - bulk load Measurable Taxonomy - bulk load Measurable Taxonomy - bulk load WIP Measurable Taxonomy - bulk load WIP Measurable Taxonomy - bulk load WIP Measurable Taxonomy - bulk load WIP Measurable Taxonomy - bulk load WIP Measurable Taxonomy - bulk load WIP Measurable Taxonomy - bulk load WIP Measurable Taxonomy - bulk load WIP Bulk measurable creation Bulk measurable creation Bulk measurable creation
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#6595