-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature(go): add support for multiple model versions #1575
base: main
Are you sure you want to change the base?
Conversation
Hi @pavelgj, @apascal07 Let me know your opinion about this approach. The only changes added were:
|
"gemini-1.0-pro": { | ||
Versions: []string{"gemini-pro", "gemini-1.0-pro-latest", "gemini-1.0-pro-001"}, | ||
Caps: gemini.BasicText, | ||
}, | ||
|
||
"gemini-1.5-flash": { | ||
Versions: []string{"gemini-1.5-flash-latest", "gemini-1.5-flash-001", "gemini-1.5-flash-002"}, | ||
Caps: gemini.Multimodal, | ||
}, | ||
|
||
"gemini-1.5-pro": { | ||
Versions: []string{"gemini-1.5-pro-latest", "gemini-1.5-pro-001", "gemini-1.5-pro-002"}, | ||
Caps: gemini.Multimodal, | ||
}, | ||
|
||
"gemini-1.5-flash-8b": { | ||
Versions: []string{"gemini-1.5-flash-8b-latest", "gemini-1.5-flash-8b-001"}, | ||
Caps: gemini.Multimodal, | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this hardcoded strings of the version management can become a bit complicated to maintain, and since we are using the same ones in googleai and vertexai, I think it would be good to have in some constants file, maybe in the genkit package or another new one, so that it is used here and in vertexai
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good observation @alonsopec89.
I was looking at how things were implemented in Genkit JS and plugins are in charge of defining the models they use regardless if more plugins are using the same models. e.g. js vertex and js googleai.
About placing these model definitions in genkit
package... my understanding is that Genkit should be model-agnostic so I believe that's the reason behind why plugins are defining their models on their packages.
Adding the support for multiple model versions and grouping the versions in the model metadata.
Gemini models being rendered in Dev UI frontpage
Model versions being grouped in the Dev UI
Playing around with
gemini-1.5-flash-8b-latest
Checking raw request
Checklist (if applicable):