Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Namespace global required method #1

Merged
merged 4 commits into from
Sep 7, 2023

Conversation

czeise
Copy link

@czeise czeise commented Sep 2, 2023

This PR fixes ruby-asana issue #45 in a way that doesn't require any updates to generated code.

We have tested this with the laddertruck Asana integration.

@shortcut-integration
Copy link

This pull request has been linked to Shortcut Story #53785: Add Asana gem to Gemfile.

@czeise czeise marked this pull request as ready for review September 6, 2023 17:34
Copy link

@jxpx777 jxpx777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple bits to delete but otherwise let's :shipit:!

spec/asana/resources/tag_spec.rb Outdated Show resolved Hide resolved
spec/asana/resources/tag_spec.rb Outdated Show resolved Hide resolved
@czeise czeise merged commit a64c611 into master Sep 7, 2023
@czeise czeise deleted the craigzeise/sc-53785-add-asana-gem branch September 7, 2023 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ruby2_0_0_compatibility.rb#required Breaks FactoryGirl on models that have a required attribute.
2 participants