Feat: add information about the ability to use --max-n-steps #2869
+23
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thibrac
requested review from
cptartur,
ddoktorski,
kkawula and
franciszekjob
as code owners
ddoktorski
requested changes
Jan 24, 2025
| .contains("RunResources has no remaining steps") | ||
| { | ||
| message | ||
| .push_str("\nSuggestion: Try increasing the steps with --max-n-steps."); |
There was a problem hiding this comment.
Suggested change
| .push_str("\nSuggestion: Try increasing the steps with --max-n-steps."); | |
| .push_str("\nSuggestion: Consider using the flag `--max-n-steps` to increase allowed limit of steps"); |
piotmag769
requested changes
Jan 24, 2025
Comment on lines
+314
to
+317
| if error | ||
| .to_string() | ||
| .contains("RunResources has no remaining steps") | ||
| { |
There was a problem hiding this comment.
It is not the way to do that, you should match the type of the error instead (as described in the issue description)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2853
Introduced changes
Checklist
CHANGELOG.md