rust: force clippy to pass in CI

foxglove · Oct 4, 2023 · 013fca8 · 013fca8
1 parent 36cea41
commit 013fca8
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 2 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -474,7 +474,7 @@ jobs:
           default: true
           components: "rustfmt, clippy"
       - run: cargo fmt --all -- --check
-      - run: cargo clippy -- --no-deps
+      - run: cargo clippy -- --no-deps -Dwarnings
       - run: cargo build
       - run: cargo test
       - name: "publish to crates.io"

diff --git a/rust/src/records.rs b/rust/src/records.rs
@@ -136,6 +136,7 @@ fn parse_vec<T: BinRead<Args<'static> = ()>>() -> BinResult<Vec<T>> {
     Ok(parsed)
 }
 
+#[allow(clippy::ptr_arg)] // needed to match binrw macros
 #[binrw::writer(writer, endian)]
 fn write_vec<T: BinWrite<Args<'static> = ()>>(v: &Vec<T>) -> BinResult<()> {
     use std::io::SeekFrom;

diff --git a/rust/src/write.rs b/rust/src/write.rs
@@ -152,7 +152,7 @@ impl WriteOptions {
     /// begin a new chunk.
     pub fn chunk_size(self, chunk_size: Option<u64>) -> Self {
         Self {
-            chunk_size: chunk_size,
+            chunk_size,
             ..self
         }
     }