lint & yarn fixes

foxglove · Nov 18, 2023 · 8fdfa66 · 8fdfa66
1 parent fb90670
commit 8fdfa66
Show file tree

Hide file tree

Showing 18 changed files with 89 additions and 88 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -14,11 +14,12 @@ jobs:
       - uses: actions/checkout@v3
         with:
           lfs: true
+      - run: corepack enable
       - uses: actions/setup-node@v4
         with:
           node-version: 20.x
           cache: yarn
-      - run: corepack enable && yarn install --immutable
+      - run: yarn install --immutable
       - run: echo '::add-matcher::.github/cspell-problem-matcher.json'
       - run: yarn spellcheck --no-progress
 
@@ -28,11 +29,12 @@ jobs:
       - uses: actions/checkout@v3
         with:
           lfs: true
+      - run: corepack enable
       - uses: actions/setup-node@v4
         with:
           node-version: 20.x
           cache: yarn
-      - run: corepack enable && yarn install --immutable
+      - run: yarn install --immutable
       - run: yarn workspace @foxglove/mcap-conformance lint:ci
       - run: yarn workspace @foxglove/mcap-conformance build
 
@@ -42,6 +44,7 @@ jobs:
       - uses: actions/checkout@v3
         with:
           lfs: true
+      - run: corepack enable
       - uses: actions/setup-node@v4
         with:
           node-version: 20.x
@@ -51,7 +54,7 @@ jobs:
           path: ~/.conan/data
           key: ${{ runner.os }}-${{ hashFiles('cpp/**/conanfile.py') }}
       - run: cd cpp && make ci
-      - run: corepack enable && yarn install --immutable
+      - run: yarn install --immutable
       - run: yarn test:conformance:generate-inputs --verify
       - run: yarn test:conformance --runner cpp-
 
@@ -61,6 +64,7 @@ jobs:
       - uses: actions/checkout@v3
         with:
           lfs: true
+      - run: corepack enable
       - uses: actions/setup-node@v4
         with:
           node-version: 20.x
@@ -69,7 +73,7 @@ jobs:
         with:
           go-version-file: go/go.work
       - run: cd go && make build-conformance-binaries
-      - run: corepack enable && yarn install --immutable
+      - run: yarn install --immutable
       - run: yarn test:conformance:generate-inputs --verify
       - run: yarn test:conformance --runner go-
 
@@ -79,6 +83,7 @@ jobs:
       - uses: actions/checkout@v3
         with:
           lfs: true
+      - run: corepack enable
       - uses: actions/setup-node@v4
         with:
           node-version: 20.x
@@ -87,7 +92,7 @@ jobs:
         with:
           python-version: 3.7
       - run: cd python && pip install -e mcap
-      - run: corepack enable && yarn install --immutable
+      - run: yarn install --immutable
       - run: yarn test:conformance:generate-inputs --verify
       - run: yarn test:conformance --runner py-
 
@@ -97,11 +102,12 @@ jobs:
       - uses: actions/checkout@v3
         with:
           lfs: true
+      - run: corepack enable
       - uses: actions/setup-node@v4
         with:
           node-version: 20.x
           cache: yarn
-      - run: corepack enable && yarn install --immutable
+      - run: yarn install --immutable
       - run: yarn test:conformance:generate-inputs --verify
       - run: yarn test:conformance --runner ts-
 
@@ -111,11 +117,12 @@ jobs:
       - uses: actions/checkout@v3
         with:
           lfs: true
+      - run: corepack enable
       - uses: actions/setup-node@v4
         with:
           node-version: 20.x
           cache: yarn
-      - run: corepack enable && yarn install --immutable
+      - run: yarn install --immutable
       - run: yarn test:conformance:generate-inputs --verify
       - run: yarn test:conformance --runner ksy-
 
@@ -125,6 +132,7 @@ jobs:
       - uses: actions/checkout@v3
         with:
           lfs: true
+      - run: corepack enable
       - uses: actions/setup-node@v4
         with:
           node-version: 20.x
@@ -133,7 +141,7 @@ jobs:
         with:
           swift-version: "5.7"
       - run: swift build
-      - run: corepack enable && yarn install --immutable
+      - run: yarn install --immutable
       - run: yarn test:conformance:generate-inputs --verify
       - run: yarn test:conformance --runner swift-
 
@@ -143,6 +151,7 @@ jobs:
       - uses: actions/checkout@v3
         with:
           lfs: true
+      - run: corepack enable
       - uses: actions/setup-node@v4
         with:
           node-version: 20.x
@@ -152,7 +161,7 @@ jobs:
           toolchain: stable
           default: true
       - run: cd rust && cargo build --example=conformance_reader
-      - run: corepack enable && yarn install --immutable
+      - run: yarn install --immutable
       - run: yarn test:conformance:generate-inputs --verify
       - run: yarn test:conformance --runner rust-
 
@@ -201,12 +210,13 @@ jobs:
       - uses: actions/checkout@v3
         with:
           lfs: true
+      - run: corepack enable
       - uses: actions/setup-node@v4
         with:
           node-version: 20.x
           cache: yarn
           registry-url: https://registry.npmjs.org
-      - run: corepack enable && yarn install --immutable
+      - run: yarn install --immutable
       - run: yarn dedupe --check
       - run: yarn prettier:check
       - run: yarn workspace @mcap/core lint:ci
@@ -250,11 +260,12 @@ jobs:
       - uses: actions/checkout@v3
         with:
           lfs: true
+      - run: corepack enable
       - uses: actions/setup-node@v4
         with:
           node-version: 20.x
           cache: yarn
-      - run: corepack enable && yarn install --immutable
+      - run: yarn install --immutable
       - run: yarn workspace @foxglove/mcap-benchmarks lint:ci
       - run: yarn workspace @foxglove/mcap-benchmarks typecheck
       - run: yarn workspace @foxglove/mcap-example-validate lint:ci

diff --git a/.github/workflows/website.yml b/.github/workflows/website.yml
@@ -14,12 +14,13 @@ jobs:
         with:
           lfs: true
 
+      - run: corepack enable
       - uses: actions/setup-node@v4
         with:
           node-version: 20.x
           cache: yarn
 
-      - run: corepack enable && yarn install --immutable
+      - run: yarn install --immutable
 
       - run: yarn workspace website lint:ci
       - run: yarn workspace website typecheck

diff --git a/.vscode/settings.json b/.vscode/settings.json
@@ -1,5 +1,6 @@
 // -*- jsonc -*-
 {
+  "editor.codeActionsOnSave": { "source.fixAll.eslint": true },
   "editor.formatOnSave": true,
   "editor.defaultFormatter": "esbenp.prettier-vscode",
 

diff --git a/tests/conformance/package.json b/tests/conformance/package.json
@@ -23,7 +23,7 @@
     "colors": "1.4.0",
     "commander": "11.1.0",
     "diff": "^5.1.0",
-    "eslint": "8.53.0",
+    "eslint": "8.54.0",
     "eslint-config-prettier": "9.0.0",
     "eslint-plugin-es": "4.1.0",
     "eslint-plugin-filenames": "1.3.2",

diff --git a/typescript/benchmarks/package.json b/typescript/benchmarks/package.json
@@ -28,7 +28,7 @@
     "@typescript-eslint/eslint-plugin": "6.11.0",
     "@typescript-eslint/parser": "6.11.0",
     "benny": "^3.7.1",
-    "eslint": "8.53.0",
+    "eslint": "8.54.0",
     "eslint-config-prettier": "9.0.0",
     "eslint-plugin-es": "4.1.0",
     "eslint-plugin-filenames": "1.3.2",

diff --git a/typescript/browser/package.json b/typescript/browser/package.json
@@ -39,9 +39,9 @@
     "@types/jest": "29.5.8",
     "@typescript-eslint/eslint-plugin": "6.11.0",
     "@typescript-eslint/parser": "6.11.0",
-    "eslint": "8.53.0",
-    "eslint-config-prettier": "8.6.0",
-    "eslint-import-resolver-typescript": "3.5.5",
+    "eslint": "8.54.0",
+    "eslint-config-prettier": "9.0.0",
+    "eslint-import-resolver-typescript": "3.6.1",
     "eslint-plugin-es": "4.1.0",
     "eslint-plugin-filenames": "1.3.2",
     "eslint-plugin-import": "2.29.0",

diff --git a/typescript/core/package.json b/typescript/core/package.json
@@ -38,7 +38,7 @@
     "@types/node": "18.13.0",
     "@typescript-eslint/eslint-plugin": "6.11.0",
     "@typescript-eslint/parser": "6.11.0",
-    "eslint": "8.53.0",
+    "eslint": "8.54.0",
     "eslint-config-prettier": "9.0.0",
     "eslint-plugin-es": "4.1.0",
     "eslint-plugin-filenames": "1.3.2",

diff --git a/typescript/examples/bag2mcap/package.json b/typescript/examples/bag2mcap/package.json
@@ -37,7 +37,7 @@
     "@typescript-eslint/eslint-plugin": "6.11.0",
     "@typescript-eslint/parser": "6.11.0",
     "commander": "11.1.0",
-    "eslint": "8.53.0",
+    "eslint": "8.54.0",
     "eslint-config-prettier": "9.0.0",
     "eslint-plugin-es": "4.1.0",
     "eslint-plugin-filenames": "1.3.2",

diff --git a/typescript/examples/basicwriter/package.json b/typescript/examples/basicwriter/package.json
@@ -25,7 +25,7 @@
     "@mcap/nodejs": "workspace:*",
     "@mcap/support": "workspace:*",
     "@types/node": "18.13.0",
-    "eslint": "8.53.0",
+    "eslint": "8.54.0",
     "eslint-config-prettier": "9.0.0",
     "eslint-plugin-es": "4.1.0",
     "eslint-plugin-filenames": "1.3.2",

diff --git a/typescript/examples/flatbufferswriter/package.json b/typescript/examples/flatbufferswriter/package.json
@@ -25,7 +25,7 @@
     "@mcap/core": "workspace:*",
     "@mcap/nodejs": "workspace:*",
     "@types/node": "18.13.0",
-    "eslint": "8.53.0",
+    "eslint": "8.54.0",
     "eslint-config-prettier": "9.0.0",
     "eslint-plugin-es": "4.1.0",
     "eslint-plugin-filenames": "1.3.2",

diff --git a/typescript/examples/text-annotation-demo/package.json b/typescript/examples/text-annotation-demo/package.json
@@ -24,7 +24,7 @@
     "@mcap/core": "workspace:*",
     "@mcap/nodejs": "workspace:*",
     "@types/node": "18.13.0",
-    "eslint": "8.53.0",
+    "eslint": "8.54.0",
     "eslint-config-prettier": "9.0.0",
     "eslint-plugin-es": "4.1.0",
     "eslint-plugin-filenames": "1.3.2",

diff --git a/typescript/examples/validate/package.json b/typescript/examples/validate/package.json
@@ -38,7 +38,7 @@
     "@typescript-eslint/eslint-plugin": "6.11.0",
     "@typescript-eslint/parser": "6.11.0",
     "commander": "11.1.0",
-    "eslint": "8.53.0",
+    "eslint": "8.54.0",
     "eslint-config-prettier": "9.0.0",
     "eslint-plugin-es": "4.1.0",
     "eslint-plugin-filenames": "1.3.2",

diff --git a/typescript/nodejs/package.json b/typescript/nodejs/package.json
@@ -40,9 +40,9 @@
     "@types/node": "18.13.0",
     "@typescript-eslint/eslint-plugin": "6.11.0",
     "@typescript-eslint/parser": "6.11.0",
-    "eslint": "8.53.0",
-    "eslint-config-prettier": "8.6.0",
-    "eslint-import-resolver-typescript": "3.5.5",
+    "eslint": "8.54.0",
+    "eslint-config-prettier": "9.0.0",
+    "eslint-import-resolver-typescript": "3.6.1",
     "eslint-plugin-es": "4.1.0",
     "eslint-plugin-filenames": "1.3.2",
     "eslint-plugin-import": "2.29.0",

diff --git a/typescript/nodejs/src/FileHandleReadable.ts b/typescript/nodejs/src/FileHandleReadable.ts
@@ -5,26 +5,26 @@ import { FileHandle } from "fs/promises";
  * IReadable implementation for FileHandle.
  */
 export class FileHandleReadable implements McapTypes.IReadable {
-  private handle: FileHandle;
-  private buffer = new ArrayBuffer(4096);
+  #handle: FileHandle;
+  #buffer = new ArrayBuffer(4096);
 
   constructor(handle: FileHandle) {
-    this.handle = handle;
+    this.#handle = handle;
   }
 
   async size(): Promise<bigint> {
-    return BigInt((await this.handle.stat()).size);
+    return BigInt((await this.#handle.stat()).size);
   }
 
   async read(offset: bigint, length: bigint): Promise<Uint8Array> {
     if (offset > Number.MAX_SAFE_INTEGER || length > Number.MAX_SAFE_INTEGER) {
       throw new Error(`Read too large: offset ${offset}, length ${length}`);
     }
-    if (length > this.buffer.byteLength) {
-      this.buffer = new ArrayBuffer(Number(length * 2n));
+    if (length > this.#buffer.byteLength) {
+      this.#buffer = new ArrayBuffer(Number(length * 2n));
     }
-    const result = await this.handle.read({
-      buffer: new DataView(this.buffer, 0, Number(length)),
+    const result = await this.#handle.read({
+      buffer: new DataView(this.#buffer, 0, Number(length)),
       position: Number(offset),
     });
     if (result.bytesRead !== Number(length)) {

diff --git a/typescript/nodejs/src/FileHandleWritable.ts b/typescript/nodejs/src/FileHandleWritable.ts
@@ -5,19 +5,19 @@ import { FileHandle } from "fs/promises";
  * IWritable implementation for FileHandle.
  */
 export class FileHandleWritable implements IWritable {
-  private handle: FileHandle;
-  private totalBytesWritten = 0;
+  #handle: FileHandle;
+  #totalBytesWritten = 0;
 
   constructor(handle: FileHandle) {
-    this.handle = handle;
+    this.#handle = handle;
   }
 
   async write(buffer: Uint8Array): Promise<void> {
-    const written = await this.handle.write(buffer);
-    this.totalBytesWritten += written.bytesWritten;
+    const written = await this.#handle.write(buffer);
+    this.#totalBytesWritten += written.bytesWritten;
   }
 
   position(): bigint {
-    return BigInt(this.totalBytesWritten);
+    return BigInt(this.#totalBytesWritten);
   }
 }
diff --git a/typescript/support/package.json b/typescript/support/package.json
@@ -39,8 +39,8 @@
     "@types/node": "18.13.0",
     "@typescript-eslint/eslint-plugin": "6.11.0",
     "@typescript-eslint/parser": "6.11.0",
-    "eslint": "8.53.0",
-    "eslint-config-prettier": "8.6.0",
+    "eslint": "8.54.0",
+    "eslint-config-prettier": "9.0.0",
     "eslint-plugin-es": "4.1.0",
     "eslint-plugin-filenames": "1.3.2",
     "eslint-plugin-import": "2.29.0",

diff --git a/website/package.json b/website/package.json
@@ -30,7 +30,7 @@
     "@types/promise-queue": "2.2.0",
     "buffer": "6.0.3",
     "classnames": "2.3.2",
-    "eslint": "8.53.0",
+    "eslint": "8.54.0",
     "eslint-config-prettier": "9.0.0",
     "eslint-plugin-es": "4.1.0",
     "eslint-plugin-filenames": "1.3.2",