Remove erroneous go install instructions
#1022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The existing instructions say that `go install` is not recommended and then proceed to give you a command that we know does not work. This change removes the incorrect command and provides a set of instructions for building the CLI from source.
james-rms
approved these changes
Nov 19, 2023
jtbandes
reviewed
Nov 20, 2023
Co-authored-by: Jacob Bandes-Storch <jacob@foxglove.dev>
jtbandes
reviewed
Nov 20, 2023
Co-authored-by: Jacob Bandes-Storch <jacob@foxglove.dev>
…-field-skipmagic-when-installing-cli-mcap-from-github
jtbandes
approved these changes
Nov 21, 2023
jtbandes
deleted the
roman/fg-5379-unknown-field-skipmagic-when-installing-cli-mcap-from-github
branch
pezy
pushed a commit
to pezy/mcap
that referenced
this pull request
Jan 11, 2024
The existing instructions say that `go install` is not recommended and then proceed to give you a command that we know does not work. This change removes the incorrect command and provides a set of instructions for building the CLI from source. Fixes: foxglove#997 --------- Co-authored-by: Jacob Bandes-Storch <jacob@foxglove.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing instructions say that
go installis not recommended and then proceed to give you a command that we know does not work. This change removes the incorrect command and provides a set of instructions for building the CLI from source.Fixes: #997