Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue where company logos become tiny on mobile device #1023

Merged
merged 3 commits into from
Nov 22, 2023
Merged

Fix issue where company logos become tiny on mobile device #1023

merged 3 commits into from
Nov 22, 2023

Conversation

esthersweon
Copy link
Contributor

Public-Facing Changes

  • Fix issue where company logos become tiny on mobile device
  • Add Dexterity logo

@esthersweon esthersweon requested a review from jtbandes November 20, 2023 20:05
@jtbandes
Copy link
Member

FYI will need to merge/rebase on #1024

@esthersweon esthersweon enabled auto-merge (squash) November 21, 2023 19:58
@jtbandes jtbandes disabled auto-merge November 21, 2023 20:01
@jtbandes
Copy link
Member

Issue doesn't really seem fixed:

image

@esthersweon
Copy link
Contributor Author

esthersweon commented Nov 21, 2023 •
edited
Loading

@jtbandes - Let logos flex-wrap naturally, instead of enforcing 3 logos per row (with adequate spacing).

Screenshot 2023-11-21 at 1 16 28 PM

jtbandes
jtbandes approved these changes Nov 21, 2023
View reviewed changes
Copy link
Member

@jtbandes jtbandes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks better. I would say the logo sizes leave something to be desired – they have different visual weights due to the difference in fonts and such between the logos. We could compensate for this by adjusting their sizes (e.g. make the coco logo smaller since its text is so large/bold, and make the tangram logo relatively larger)

@esthersweon esthersweon merged commit 83c0428 into main Nov 22, 2023
24 checks passed
@esthersweon esthersweon deleted the esther/fg-5748 branch November 22, 2023 18:51
@esthersweon
Copy link
Contributor Author

@jtbandes - will follow up with making logos more consistent in size / spacing. cc: @2metres

pezy pushed a commit to pezy/mcap that referenced this pull request Jan 11, 2024
@esthersweon @pezy
Fix issue where company logos become tiny on mobile device (foxglove#…
b5f7ce3 
…1023)

### Public-Facing Changes

- Fix issue where company logos become tiny on mobile device
- Add Dexterity logo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtbandes jtbandes jtbandes approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@esthersweon @jtbandes