Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move corepack enable before actions/setup-node #1024

Merged
merged 2 commits into from
Nov 20, 2023
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 22 additions & 11 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,11 +14,12 @@ jobs:
- uses: actions/checkout@v3
with:
lfs: true
- run: corepack enable
- uses: actions/setup-node@v4
with:
node-version: 20.x
cache: yarn
- run: corepack enable && yarn install --immutable
- run: yarn install --immutable
- run: echo '::add-matcher::.github/cspell-problem-matcher.json'
- run: yarn spellcheck --no-progress

Expand All @@ -28,11 +29,12 @@ jobs:
- uses: actions/checkout@v3
with:
lfs: true
- run: corepack enable
- uses: actions/setup-node@v4
with:
node-version: 20.x
cache: yarn
- run: corepack enable && yarn install --immutable
- run: yarn install --immutable
- run: yarn workspace @foxglove/mcap-conformance lint:ci
- run: yarn workspace @foxglove/mcap-conformance typecheck

Expand All @@ -42,6 +44,7 @@ jobs:
- uses: actions/checkout@v3
with:
lfs: true
- run: corepack enable
- uses: actions/setup-node@v4
with:
node-version: 20.x
Expand All @@ -51,7 +54,7 @@ jobs:
path: ~/.conan/data
key: ${{ runner.os }}-${{ hashFiles('cpp/**/conanfile.py') }}
- run: cd cpp && make ci
- run: corepack enable && yarn install --immutable
- run: yarn install --immutable
- run: yarn test:conformance:generate-inputs --verify
- run: yarn test:conformance --runner cpp-

Expand All @@ -61,6 +64,7 @@ jobs:
- uses: actions/checkout@v3
with:
lfs: true
- run: corepack enable
- uses: actions/setup-node@v4
with:
node-version: 20.x
Expand All @@ -69,7 +73,7 @@ jobs:
with:
go-version-file: go/go.work
- run: cd go && make build-conformance-binaries
- run: corepack enable && yarn install --immutable
- run: yarn install --immutable
- run: yarn test:conformance:generate-inputs --verify
- run: yarn test:conformance --runner go-

Expand All @@ -79,6 +83,7 @@ jobs:
- uses: actions/checkout@v3
with:
lfs: true
- run: corepack enable
- uses: actions/setup-node@v4
with:
node-version: 20.x
Expand All @@ -87,7 +92,7 @@ jobs:
with:
python-version: 3.7
- run: cd python && pip install -e mcap
- run: corepack enable && yarn install --immutable
- run: yarn install --immutable
- run: yarn test:conformance:generate-inputs --verify
- run: yarn test:conformance --runner py-

Expand All @@ -97,11 +102,12 @@ jobs:
- uses: actions/checkout@v3
with:
lfs: true
- run: corepack enable
- uses: actions/setup-node@v4
with:
node-version: 20.x
cache: yarn
- run: corepack enable && yarn install --immutable
- run: yarn install --immutable
- run: yarn test:conformance:generate-inputs --verify
- run: yarn test:conformance --runner ts-

Expand All @@ -111,11 +117,12 @@ jobs:
- uses: actions/checkout@v3
with:
lfs: true
- run: corepack enable
- uses: actions/setup-node@v4
with:
node-version: 20.x
cache: yarn
- run: corepack enable && yarn install --immutable
- run: yarn install --immutable
- run: yarn test:conformance:generate-inputs --verify
- run: yarn test:conformance --runner ksy-

Expand All @@ -125,6 +132,7 @@ jobs:
- uses: actions/checkout@v3
with:
lfs: true
- run: corepack enable
- uses: actions/setup-node@v4
with:
node-version: 20.x
Expand All @@ -133,7 +141,7 @@ jobs:
with:
swift-version: "5.7"
- run: swift build
- run: corepack enable && yarn install --immutable
- run: yarn install --immutable
- run: yarn test:conformance:generate-inputs --verify
- run: yarn test:conformance --runner swift-

Expand All @@ -143,6 +151,7 @@ jobs:
- uses: actions/checkout@v3
with:
lfs: true
- run: corepack enable
- uses: actions/setup-node@v4
with:
node-version: 20.x
Expand All @@ -152,7 +161,7 @@ jobs:
toolchain: stable
default: true
- run: cd rust && cargo build --example=conformance_reader
- run: corepack enable && yarn install --immutable
- run: yarn install --immutable
- run: yarn test:conformance:generate-inputs --verify
- run: yarn test:conformance --runner rust-

Expand Down Expand Up @@ -201,12 +210,13 @@ jobs:
- uses: actions/checkout@v3
with:
lfs: true
- run: corepack enable
- uses: actions/setup-node@v4
with:
node-version: 20.x
cache: yarn
registry-url: https://registry.npmjs.org
- run: corepack enable && yarn install --immutable
- run: yarn install --immutable
- run: yarn dedupe --check
- run: yarn prettier:check
- run: yarn workspace @mcap/core lint:ci
Expand All @@ -225,11 +235,12 @@ jobs:
- uses: actions/checkout@v3
with:
lfs: true
- run: corepack enable
- uses: actions/setup-node@v4
with:
node-version: 20.x
cache: yarn
- run: corepack enable && yarn install --immutable
- run: yarn install --immutable
- run: yarn workspace @foxglove/mcap-benchmarks lint:ci
- run: yarn workspace @foxglove/mcap-benchmarks typecheck
- run: yarn workspace @foxglove/mcap-example-validate lint:ci
Expand Down
Loading