ci.yml: use OIDC connect to publish pypi packages #1029
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
defunctzombie
approved these changes
Nov 26, 2023
pezy
pushed a commit
to pezy/mcap
that referenced
this pull request
Jan 11, 2024
### Public-Facing Changes None. ### Description I previously configured OIDC in pypi and test.pypi for all of our MCAP packages, see for example https://pypi.org/manage/project/mcap-protobuf-support/settings/publishing/ This PR switches CI over to using that auth method. Once this is done, I can invalidate our API tokens, and we can remove the PYPI_TOKEN github secrets from this repo. <!-- describe what has changed, and motivation behind those changes --> <!-- Link relevant Github issues. Use `Fixes foxglove#1234` to auto-close the issue after merging. -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Public-Facing Changes
None.
Description
I previously configured OIDC in pypi and test.pypi for all of our MCAP packages, see for example https://pypi.org/manage/project/mcap-protobuf-support/settings/publishing/
This PR switches CI over to using that auth method.
Once this is done, I can invalidate our API tokens, and we can remove the PYPI_TOKEN github secrets from this repo.