Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update company logos on the homepage with similar dimensions, padding… #1040

Conversation

ocin-rye
Copy link
Contributor

…, and format

Public-Facing Changes

Removed padding, aligned the heights, and matched the format of company logo images.

Description

To address the lack of consistent spacing for logo assets on MCAP websites.

@esthersweon
Copy link
Contributor

@ocin-rye - The assets themselves look great, but we need to add styling to make these new logos show up correctly.
I will take this PR over to implement.

What I see:
Screenshot 2023-12-11 at 1 29 17 PM
Screenshot 2023-12-11 at 1 29 23 PM

@ocin-rye
Copy link
Contributor Author

@ocin-rye - The assets themselves look great, but we need to add styling to make these new logos show up correctly. I will take this PR over to implement.

What I see: Screenshot 2023-12-11 at 1 29 17 PM Screenshot 2023-12-11 at 1 29 23 PM

Thanks! 🙏 I'll change the assignee on linear to you.

Copy link
Contributor

@esthersweon esthersweon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Need updated Tangram logo (light mode) with correct fill areas
  • Need updated Dexterity logo (smaller)

Copy link
Contributor

@esthersweon esthersweon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some padding, but looks great otherwise!

@esthersweon esthersweon enabled auto-merge (squash) December 14, 2023 18:53
@ocin-rye ocin-rye disabled auto-merge December 15, 2023 20:50
@banisadr banisadr changed the base branch from main to dependabot/github_actions/actions/checkout-4 December 18, 2023 23:34
@banisadr banisadr changed the base branch from dependabot/github_actions/actions/checkout-4 to main December 18, 2023 23:34
@esthersweon esthersweon enabled auto-merge (squash) December 18, 2023 23:53
@esthersweon esthersweon merged commit 16e63f9 into main Dec 18, 2023
25 checks passed
@esthersweon esthersweon deleted the ocin-rye/fg-6070-remove-padding-and-align-company-logo-heights branch December 18, 2023 23:56
pezy pushed a commit to pezy/mcap that referenced this pull request Jan 11, 2024
foxglove#1040)

…, and format

### Public-Facing Changes

Removed padding, aligned the heights, and matched the format of company
logo images.

### Description

To address the lack of consistent spacing for logo assets on MCAP
websites.

---------

Co-authored-by: Esther Weon <esther.s.weon@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants