libpkg: fix regressions in ELF arch parsing #2358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since c2fe22b, most non-amd64 architectures are parsed inadequately from ELF files. This commit fixes the regression for architectures supported by FreeBSD 14.x. It also adds tests for these architectures to prevent possible regressions in the future. Note that not all regressions in architecture parsing from c2fe22b have been fixed. The mips variants for example remain broken even with this commit due to lack of test binaries. Sponsored by: The FreeBSD Foundation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since c2fe22b, most non-amd64 architectures are parsed inadequately from ELF files. This commit fixes the regression for architectures supported by FreeBSD 14.x.
It also adds tests for these architectures to prevent possible regressions in the future.
Note that not all regressions in architecture parsing from c2fe22b have been fixed. The mips variants for example remain broken even with this commit due to lack of test binaries.
Sponsored by: The FreeBSD Foundation