Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ffac-ssid-changer: switch to ubus call to reload hostapd and fix OWE offline ssid #114

Merged
merged 3 commits into from
Jun 10, 2024

Conversation

maurerle
Copy link
Member

@maurerle maurerle commented Jun 9, 2024

not yet fully tested, but this should include hotfixes to solve:

fix copy paste mistake in ONLINE_SSID_OWE

use correct ONLINE_SSID_OWE to set offline state for OWE as well

this still does not work with transition mode

fixes #113

fix reload of wifi config using ubus

until a fix based on freifunk-gluon/gluon#3223 is available

use ubus call hostapd reload instead of broken HUP

fixes #93

fix for radio named wl

don't rely on hostapd radio name starting with phy

some devices have a radio named wl0 and wl1 instead in openwrt 23.05
This is a workaround, until a better fix using lua is available

fixes #39

until a better version of the ssid-changer will be available

@rotanid
Copy link
Member

rotanid commented Jun 9, 2024

@maurerle your PR has merge conflicts, please resolve them.

usually, your two changes should be separate commits, but as it is the community repo, well ^^

@maurerle maurerle force-pushed the fixes_for_ssid_changer branch from efec32a to 7bd8610 Compare June 10, 2024 06:50
@maurerle maurerle force-pushed the fixes_for_ssid_changer branch from 7bd8610 to f1e4678 Compare June 10, 2024 06:54
some devices have a radio named wl0 and wl1 instead in openwrt 23.05
This is a workaround, until a better fix using lua is available

fixes #39
@maurerle maurerle changed the title switch to ubus call to reload hostapd and fix OWE offline ssid ffac-ssid-changer: switch to ubus call to reload hostapd and fix OWE offline ssid Jun 10, 2024
@grische
Copy link
Contributor

grische commented Jun 10, 2024

I tested this on a Cudy WR3000 and it seems to fix the issue that the SSID did not get renamed (no OWE, no wl phy).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants