ffmuc-mesh-vpn-wireguard-vxlan: several improvements #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maurerle
approved these changes
Mar 17, 2024
ffmuc-mesh-vpn-wireguard-vxlan/luasrc/lib/gluon/upgrade/400-mesh-vpn-wireguard
Outdated
Show resolved
Hide resolved
ffmuc-mesh-vpn-wireguard-vxlan/luasrc/lib/gluon/upgrade/400-mesh-vpn-wireguard
Show resolved
Hide resolved
grische
force-pushed
the
fix/improve-ffmuc-wireguard-package
branch
from
9e07ff4 to
e70f2e1
Compare
grische
force-pushed
the
fix/improve-ffmuc-wireguard-package
branch
from
e70f2e1 to
06d50eb
Compare
This is currently not working as intended. If the variable does not exist, the get_bool returns false and with the not in front, this is always true and hence always enables mesh_vpn while the default fallback should be mesh_vpn off.
Some legacy code set the value to "true" instead of "1". While those should be overwritten by gluon-reconfigure, warn if such cases still exist.
grische
force-pushed
the
fix/improve-ffmuc-wireguard-package
branch
from
06d50eb to
8dbcd46
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Include: