Add an environment variable to disable scale adjustment based on detected DPI #5359
Conversation
|
I doubt many Linux users will set this environment variable. Is it not better to fix the issue and/or rework how we handle window scaling? Something is obviously wrong there from what I can tell from the ticket. |
|
There's two separate things being discussed in the ticket. The original conversation was about something that's not a bug, but a user preference to disable a window re-adjusting its scale when moving between monitors. This PR is for that topic |
|
Alright then but maybe it is better to add it into fyne_settings instead in that case? We could add a page for advanced options. My gripe with this is that a user needs to read the documentation to know that the environment variable exists (that needs to be maintained and not rot away as well) and then define it either for each app individually or globally. I doubt many users will do so. |
We could do that as well, similar to how FYNE_SCALE is done (I think). I'd like to avoid a Fyne app user having to download and run a different app (fyne settings) to adjust this. |
You can embed the Fyne settings panel in your app if you like :) |
Won't that adjust it for all apps though instead of just mine? Which is not what the user would expect. And also I already have my own settings UI with other settings specific to my app. I can add this to the fyne_settings app as well though, keeping in mind it would need a new public getter API like What do you think? |
Yes |
If the app is sandboxed, like Flatpak for example, then it is only for your application. |
Yes, though not all installations will be Flatpak. It sounds like you're in favor of adding a settings app control for this as well as the env var? |
| // check if DPI detection is disabled | ||
| env := os.Getenv(disableDPIDetectionEnvKey) | ||
| switch env { | ||
| case "True", "TRUE", "true", "T", "t", "1": |
There was a problem hiding this comment.
You might want to use strings.EqualFold instead of hardcoding values. That should allow the word "true" no matter how it is capitalised.
| case "True", "TRUE", "true", "T", "t", "1": | ||
| return 1 | ||
| } | ||
|
|
||
| if build.IsWayland { // Wayland controls scale through content scaling |
There was a problem hiding this comment.
I think it would be wise to move the env check to after this check. In the case of Wayland, there is no need to check the environment variable at all and the compiler can just deadcode eliminate most of the function.
Indeed. I just wanted to add that information to the discussion :)
Was this meant as a setting mostly to help out on Linux or is it useful on all platforms? I was initially in favour of the settings page but in my latest review I looked at the code and saw that Wayland handles scaling themselves. If it is Linux specific, it seems strange to add a settings toggle for it when Wayland will take over eventually (not talking about the ENV var). |
|
I do think it is mainly a Linux X11 thing, since at least MacOS handles it at the OS level I think (not really sure about Windows). So yeah maybe just env var makes sense. |
macOS and Windows provide a system check first - so global user settings are respected. |
|
Are there any other code suggestions for this? |
Description:
Adds a new environment variable
FYNE_DISABLE_DPI_DETECTIONwhich can be set totrue,True,TRUEor1to disable detecting the screen DPI and adjusting scaling accordingly.I do not have a dual-monitor Linux setup so I can only confirm that it results in a new Fyne app being drawn at 1:1 pixel scale on a Hi-DPI monitor.
Fixes #5164
Checklist: