-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework bindings to avoid generator script entirely #5483
Conversation
2eed6b1
to
99cacc8
Compare
FYI: The |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much for this cleaner code and for getting our coverage back up :)
Description:
Working on removing the last bits of code duplication and generator scripts within data bindings. With this landing, the code cleanup is complete, I think. Conversions are now handled by generic implementations and the other generic implementations in
generic.go
have been moved into their own files again (I also removed a generic interface that accidentally existed twice using two different names).Fixes #5378
Checklist: