Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework bindings to avoid generator script entirely #5483

Merged
merged 11 commits into from
Feb 5, 2025

Conversation

Jacalz
Copy link
Member

@Jacalz Jacalz commented Jan 31, 2025

Description:

Working on removing the last bits of code duplication and generator scripts within data bindings. With this landing, the code cleanup is complete, I think. Conversions are now handled by generic implementations and the other generic implementations in generic.go have been moved into their own files again (I also removed a generic interface that accidentally existed twice using two different names).

Fixes #5378

Checklist:

  • Tests included.
  • Lint and formatter run with no errors.
  • Tests all pass.

@coveralls
Copy link

coveralls commented Jan 31, 2025

Coverage Status

coverage: 62.571% (-0.06%) from 62.633%
when pulling 038a5d2 on Jacalz:binding-convertion-cleanup
into d2f7fe7 on fyne-io:develop.

@Jacalz Jacalz marked this pull request as ready for review February 2, 2025 09:49
@Jacalz Jacalz force-pushed the binding-convertion-cleanup branch from 2eed6b1 to 99cacc8 Compare February 4, 2025 20:26
@Jacalz Jacalz requested a review from dweymouth February 4, 2025 22:27
@Jacalz
Copy link
Member Author

Jacalz commented Feb 5, 2025

FYI: The convert.go related files are the ones with the only new code. All other binding files are basically just code moved out from the generic.go file except for one duplicated interface that was removed.

@Jacalz Jacalz requested a review from andydotxyz February 5, 2025 08:58
Copy link
Member

@andydotxyz andydotxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for this cleaner code and for getting our coverage back up :)

@Jacalz Jacalz merged commit 09ba93b into fyne-io:develop Feb 5, 2025
11 checks passed
@Jacalz Jacalz deleted the binding-convertion-cleanup branch February 5, 2025 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants