-
-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP][FEATURE] Add new notifications feature #104
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe wanna move that to the 8lts branch and use php7 features as well?
*/ | ||
protected function getFluidTemplate(array $arguments, $file, $format = 'html') | ||
{ | ||
/** @var StandaloneView $renderer */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I try to avoid those lines
*/ | ||
protected $channels; | ||
|
||
/** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wanna move the /** @var array */ syntax? because no description will be used and will save some lines.
/** | ||
* Send notification to all configured channels | ||
*/ | ||
public function send() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's follow cgl, new lines
->setTo($this->getOptions()['recipientAddress']) | ||
->setBody($notification->getMessage()) | ||
->setContentType('text/plain'); | ||
$mailMessage->send(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we check response?
No description provided.